From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54167 invoked by alias); 25 Jul 2018 16:51:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54133 invoked by uid 89); 25 Jul 2018 16:51:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1531173 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.200) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jul 2018 16:51:06 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 701353D0B73 for ; Wed, 25 Jul 2018 11:51:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iMzQfA0x4bXuJiMzsfGZVy; Wed, 25 Jul 2018 11:51:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+finL+eKDXP7Z51J+LgQpuEiaZ1Aahh5UxAcTuEKwg8=; b=XfG96n6L2oCbsm6rC64vS4jjg1 AG8AT+liIqs7lnk5g4azJVe+UBMhGXNuzlVB0vEL2Wk6pQ5AAphO6xBrlkC5JZIgTwTmv1T3aBl+O Vh0/Px/5K1lNB3ihYjypW8D81; Received: from [75.166.85.72] (port=35386 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fiMzP-002l9u-RK; Wed, 25 Jul 2018 11:50:15 -0500 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH 1/3] Make index reading functions more modular References: <1531173351-6351-1-git-send-email-simon.marchi@ericsson.com> <1531173351-6351-2-git-send-email-simon.marchi@ericsson.com> Date: Wed, 25 Jul 2018 16:51:00 -0000 In-Reply-To: <1531173351-6351-2-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 9 Jul 2018 17:55:49 -0400") Message-ID: <87muuf1cqi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00695.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The read_gdb_index_from_section and read_debug_names_from_section Simon> functions read the index content, as their names state, from sections of Simon> object files. A following patch will make it possible to read index Simon> content from standalone files. Simon> This patch therefore decouples the code that reads the index content Simon> from the code that processes that content. Functions Simon> dwarf2_read_gdb_index and dwarf2_read_debug_names receive callbacks that Simon> are responsible for providing the index contents (for both the main file Simon> and the potential dwz file). I think this looks reasonable. (I was hoping there would be some way to do it without callbacks, but I didn't see a good approach to that, and I'd guess you didn't either.) Tom