From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48110 invoked by alias); 28 Aug 2018 17:46:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48096 invoked by uid 89); 28 Aug 2018 17:46:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:46:52 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 63E694A855 for ; Tue, 28 Aug 2018 12:46:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ui4OfvfCLBcCXui4efQ4cw; Tue, 28 Aug 2018 12:46:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kdKpqd45CBl9IbmCfAkTDb9+hT0D2k79K/9isQ7c3ww=; b=hmKmDsqqOdcgt7KaawcLPI6Rbl kWsRtLWu/x5/HzWRpIutPhf6ckFdpFnoZLOrvt4OpoU7ddIAApuVuGZAk4a/d+yQ7Emj/M0spO+S+ yhegnhRJSbnVohzurKxusROPa; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47974 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fui4O-001xrS-9p; Tue, 28 Aug 2018 12:46:24 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] Change decode_compound_collector to use std::vector References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-6-keiths@redhat.com> <87pnypt086.fsf@tromey.com> <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com> Date: Tue, 28 Aug 2018 17:46:00 -0000 In-Reply-To: <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com> (Keith Seitz's message of "Fri, 17 Aug 2018 11:04:07 -0700") Message-ID: <87mut65qq8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00701.txt.bz2 >>>>> "Keith" == Keith Seitz writes: >> Won't this end up copying m_symbols? Keith> Yup. Forgot to move the return value (which would also clear/reset m_symbols Keith> as expected today). Keith> This patch has one additional change over v1: the final qsort is replaced with Keith> std::sort and the temporary std_compare_symbol function replaces the Keith> qsort-oriented compare_symbol function (mentioned in a previous patch email). Thanks, this is ok. Tom