From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121044 invoked by alias); 15 Sep 2018 21:12:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121032 invoked by uid 89); 15 Sep 2018 21:12:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Sep 2018 21:12:39 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id D713618D5 for ; Sat, 15 Sep 2018 16:12:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1HrlgxZUikBj61Hrlg83UD; Sat, 15 Sep 2018 16:12:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qnBuTMZ51c/jpFolyr03hCGMPnzBb2NKlxL2SF4ACng=; b=G2hu4VwCiUFcl3Y3peSA0fGT1O kn5V8Rvrn4xG4zd7uEHE7HwOkT4Vf1eh0caUKiD5BsN3Cl79jdFnhD3h0/m6z1NG5Otgk1XtuzFSv 2ssJn7z/cMs+GK3X76AVdSSj5; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:45580 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1Hrl-000d5t-Kq; Sat, 15 Sep 2018 16:12:33 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Make "list" work again in TUI References: <20180908143153.18583-1-tom@tromey.com> <87musq4jdk.fsf@tromey.com> <66752a61-08f1-5588-691d-205e89b09471@redhat.com> Date: Sat, 15 Sep 2018 21:12:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 12 Sep 2018 13:31:41 +0100") Message-ID: <87musiqxbz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00502.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Something to keep in mind, though, is avoiding refreshes/updates Pedro> caused by temporary thread stops while the target is running. Pedro> E.g., if we have breakpoints with conditions that eval false, Pedro> or e.g. a software watchpoint, we don't want the intermediate Pedro> stops to cause a flurry of source window refreshes. I'm not Pedro> sure whether that would invalidate what I said above, depends on Pedro> when set_current_source_symtab_and_line is called, I suppose, Pedro> but now I'm thinking that it probably does. The troubling call is to set_current_sal_from_frame in normal_stop. It seems like that one will be called frequently. However one idea might be to have the TUI observer just set a flag, and then continue to do the actual work in the prompt hook. Pedro> That might suggest instead to start by seeing about trying to remove Pedro> the select_source_symtab call from tui_refresh_frame_and_register_information. Pedro> Why do we need that? Can we remove it and instead see about making Pedro> tui_refresh_frame_and_register_information update the source window Pedro> from get_current_source_symtab_and_line, if set_current_source_symtab_and_line Pedro> was meanwhile called? I.e., refresh the source window if something changed Pedro> "list"'s current source&line. I'm going to give it a try. Tom