From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom Tromey <tom@tromey.com>, Andreas Schwab <schwab@suse.de>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Do not accidentally include in-tree readline headers
Date: Wed, 26 Sep 2018 20:19:00 -0000 [thread overview]
Message-ID: <87mus4j9mv.fsf@tromey.com> (raw)
In-Reply-To: <20180926164743.GM5952@embecosm.com> (Andrew Burgess's message of "Wed, 26 Sep 2018 17:47:43 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> I don't really understand what the last sentence is telling me. It
Andrew> feels like there's a bit missing from the end...
Oops, sorry. I changed it to:
The basic problem is that OPCODES_CFLAGS uses -I$(OPCODES_SRC)/.. so
that #include "opcodes/..." works. However, this also makes it so the
#include <readline/...> includes are found in the srcdir.
Tom
next prev parent reply other threads:[~2018-09-26 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 12:59 Tom Tromey
2018-09-26 13:12 ` Andreas Schwab
2018-09-26 13:57 ` Tom Tromey
2018-09-26 16:47 ` Andrew Burgess
2018-09-26 20:19 ` Tom Tromey [this message]
2018-10-07 4:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mus4j9mv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox