From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57252 invoked by alias); 20 Nov 2018 22:18:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57237 invoked by uid 89); 20 Nov 2018 22:18:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Nov 2018 22:18:02 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id C67EE751B8 for ; Tue, 20 Nov 2018 16:18:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PELIguuOiFxNhPELIg7cXm; Tue, 20 Nov 2018 16:18:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EsBDBRroHGcBoXz9QiWIHwMwiq/ag+TAb5DrovVAtbw=; b=I/CP7NR7Q3l7gx5dS0oWVxVgqo pocm7ALlkbqG5chMRr9Uu+XhdOiWvFjVeGtraSaEK3nLvwqsBoge8eeBfyEdrZJXGTxTVoWrQ6mc5 qHhnmuAFfyYNqT1sN22Qf/4dO; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:50762 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gPELI-002kN6-Ik; Tue, 20 Nov 2018 16:18:00 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Use string_printf to format int fields instead of a fixed size buffer References: <81914f01b8c70c20744c2960c4a71136bcb6e913.1542745482.git.andrew.burgess@embecosm.com> Date: Tue, 20 Nov 2018 22:18:00 -0000 In-Reply-To: <81914f01b8c70c20744c2960c4a71136bcb6e913.1542745482.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 20 Nov 2018 20:30:06 +0000") Message-ID: <87muq3o0ko.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00346.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This patch removes a FIXME comment from cli-out.c, now instead of Andrew> formatting integers into a fixed size buffer we build a std::string Andrew> and extract the formatted integer from that. Andrew> The old code using a fixed size buffer was probably fine (the integer Andrew> was not going to overflow it) and probably slightly more efficient Andrew> (avoids building a std::string) however, given we already have utility Andrew> code in GDB that will allow the 'FIXME' comment to be removed, it Andrew> seems like an easy improvement. Andrew> gdb/ChangeLog: Andrew> * cli-out.c (cli_ui_out::do_field_int): Use string_printf rather Andrew> than a fixed size buffer. Thanks. This is ok. Tom