From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90167 invoked by alias); 26 Nov 2018 16:29:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90143 invoked by uid 89); 26 Nov 2018 16:29:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=email!, tells, states, encrypted X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 16:29:06 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D70EB946; Mon, 26 Nov 2018 16:29:05 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 097B260BEC; Mon, 26 Nov 2018 16:29:04 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: Simon Marchi , GDB Patches , Alan Hayward , nd Subject: Re: [PATCH v2] Implement timestamp'ed output on "make check" References: <20181122221240.15354-1-sergiodj@redhat.com> <20181123150256.22584-1-sergiodj@redhat.com> <61b6c448-bae1-2dd9-87a7-5c500be0aa09@ericsson.com> <87wop13z2z.fsf@redhat.com> <147c28c03427ad7e1e6a9dfd976b027a@polymtl.ca> <877eh04u8g.fsf@redhat.com> <5417842c2c8843e89f4390cd052c93a5@polymtl.ca> Date: Mon, 26 Nov 2018 16:29:00 -0000 In-Reply-To: <5417842c2c8843e89f4390cd052c93a5@polymtl.ca> (Simon Marchi's message of "Sun, 25 Nov 2018 19:47:01 -0500") Message-ID: <87mupv3ir3.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00439.txt.bz2 On Sunday, November 25 2018, Simon Marchi wrote: > On 2018-11-25 18:23, Sergio Durigan Junior wrote: >> Ah, OK. I'm not used to tools that don't ask me whether I'd like to >> modify a file. > > The -i switch tells it to modify the file in-place, otherwise it > outputs on stdout. I thought -i was for "information". My bad for not reading the documentation. >> And FWIW, I don't really like this part of PEP8 which >> states that there should be no spaces before parentheses. > > If you hate it that much, feel free to propose a change to our > standards :) Sorry if it appeared that I was complaining about your email! Not my intention at all, and I do appreciate your reviews. As for proposing a change to the standards... that's a good idea! I've played a little bit with "autopep8" here, and it seems to be a nice little tool which offers the possibility of ignoring parts of the PEP8 spec when fixing the file. For example, for the specific case of "whitespace before '('", if you do: autopep8 --ignore E211 -i FILE It will not fix the "issue", and will preserve the whitespaces there. Neat. Anyway, I just wanted to document that I found a way to disable this specific extension. As much as I'd like us to change this specific thing, I'll focus on other priorities right now. Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/