From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66346 invoked by alias); 15 Jan 2019 22:33:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65898 invoked by uid 89); 15 Jan 2019 22:33:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 22:33:14 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 9935C7189 for ; Tue, 15 Jan 2019 16:33:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id jXGjg8TiJ2PzOjXGjgl7gF; Tue, 15 Jan 2019 16:33:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gr+DUmdedr+Ywr6/Dodi8jvmnoPgGx+e4qEQMqLwdjw=; b=SM+QHKR+nWBNZcFWhmbZ4GXVtc rPAguWi0pZ2JnMB4Zyca5Bb5YS/+vV04PwJVPgrE2V9PajySIx7juOsFgMhdNDGpDQIDWdZeHPvPt WrhidUHWOmosT1c/SOqhJGzgM; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:49392 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gjXGj-001ofy-Bt; Tue, 15 Jan 2019 16:33:13 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [RFA] Fix leaks in macro definitions. References: <20190115055611.17967-1-philippe.waroquiers@skynet.be> <63b6768fbedbe46b7a46f0d29f7b178c@polymtl.ca> <87h8e9on9h.fsf@tromey.com> <884d32995ce9ac8f412e22b5207d9a6d@polymtl.ca> <87d0oxoiv3.fsf@tromey.com> Date: Tue, 15 Jan 2019 22:33:00 -0000 In-Reply-To: <87d0oxoiv3.fsf@tromey.com> (Tom Tromey's message of "Tue, 15 Jan 2019 11:50:40 -0700") Message-ID: <87muo1tutz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00360.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> I think it would be best by far to fix this in splay_tree_remove. Tom> I agree it's hard, but working around this seems worse to me. I looked, and there is one spot in gcc that passes a key deletion function, and one spot in binutils-gdb (the spot in question). The module in gcc (gcc/lto/lto.c) does not call splay_tree_remove. So, I think landing the fix upstream in gcc should be totally fine. Tom