From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75958 invoked by alias); 15 Feb 2019 19:49:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75946 invoked by uid 89); 15 Feb 2019 19:49:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Feb 2019 19:49:49 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id CE551400CDBAB for ; Fri, 15 Feb 2019 13:49:47 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ujUZgOx5S90onujUZgllnS; Fri, 15 Feb 2019 13:49:47 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zio/AXyYBwusroM/bF6MbaAZjePvSk/hjIyu7U0Kgzo=; b=bAKsbcAM0AAR7fY1bm9+QxNshT FxorB7oKXOjxeXBk483oulxDrhFVjyHs3vwy9SanMVoTOSh1y/TfFuZ9LYa+Il7SrnWOzfVNtRQAY onbRcgnVSABx8um0gtNcc/XRS; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:41234 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gujUZ-002zPN-EL; Fri, 15 Feb 2019 13:49:47 -0600 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] (Ada) fix GDB crash printing packed array References: <1549786901-77868-1-git-send-email-brobecker@adacore.com> Date: Fri, 15 Feb 2019 19:49:00 -0000 In-Reply-To: <1549786901-77868-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sun, 10 Feb 2019 03:21:41 -0500") Message-ID: <87mumwzvad.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00255.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> (1) Forcing the lookup into language_c currently does not affect Joel> how symbol matching is done anymore, because we look at the symbol's Joel> language to determine which kind of matching should be done; There's also this code in get_symbol_name_matcher: /* If currently in Ada mode, and the lookup name is wrapped in '<...>', hijack all symbol name comparisons using the Ada matcher, which handles the verbatim matching. */ if (current_language->la_language == language_ada && lookup_name.ada ().verbatim_p ()) return current_language->la_get_symbol_name_matcher (lookup_name); I don't know if this could be removed, but if so it would be better to do so. The patch looks fine to me. Tom