Re: [PATCH] Add an objfile getter to gdb.Type

Christian Biesinger via gdb-patches
2019-05-23T21:25:56Z

On Thu, May 23, 2019 at 4:06 PM Simon Marchi <simark@simark.ca> wrote:
> Just some formatting nits (don't worry that's common when starting on a project, but you get used to it quickly).

No problem! Will send a new version of the patch in a second.

> On 2019-05-23 4:32 p.m., Christian Biesinger via gdb-patches wrote:
> > diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp
> > index 734f9b40fd..c299fa3410 100644
> > --- a/gdb/testsuite/gdb.python/py-type.exp
> > +++ b/gdb/testsuite/gdb.python/py-type.exp
> > @@ -98,6 +98,8 @@ proc test_fields {lang} {
> > gdb_py_test_silent_cmd "print (st)" "print value (st)" 1
> > gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value (st) from history" 1
> > gdb_py_test_silent_cmd "python fields = st.type.fields()" "get fields from st.type" 1
> > + gdb_test "python print (st.type.objfile.filename == gdb.current_progspace().filename)" "True" \
>
> Space after current_progspace as well.
>
> > + "Check type.objfile"
>
> We use lower case letters for test names.

This file is super inconsistent about both of those :/