Re: [PATCH] Add an objfile getter to gdb.Type

Christian Biesinger via gdb-patches
2019-05-30T17:01:50Z

On Tue, May 28, 2019 at 5:07 PM Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
> Christian> This allows users of the Python API to find the objfile where a type
> Christian> was defined.
>
> Could you say what your motivation is for adding this?
>
> The reason I ask is that I still harbor some hopes that we can complete
> the "objfile splitting" project, and if so, then it wouldn't be possible
> to associate a type with a single objfile.
>
> I suppose maybe we could make the Python wrappers per-objfile. So, this
> patch maybe wouldn't necessarily limit this.

I'm not sure what the objfile splitting this is about, but the
motivation is as follows. I want to use this API for better supporting
a project called JsDbg, which is basically (for the purpose of this
question) a data structure visualizer for multiple debuggers
(https://github.com/MicrosoftEdge/JsDbg/blob/master/docs/FEATURES.md).
I would like access to the objfile (really I just care about the name
of the shared library/executable) to disambiguate typenames that may
be the same in different solibs. I know that this doesn't handle the
case where the different solibs are all loaded in the same process,
but that should be ok.

Does that sound reasonable?

Christian

>
> The patch itself looks fine to me.
>
> Tom