From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84377 invoked by alias); 1 Jul 2019 17:20:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84368 invoked by uid 89); 1 Jul 2019 17:20:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jul 2019 17:20:27 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 7FF4842342 for ; Mon, 1 Jul 2019 12:20:26 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id hzychSRIL90onhzychPMLS; Mon, 01 Jul 2019 12:20:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OGSw2llZ40RVbv1P2CniieTku/TmXb7wWj3J/rKCtII=; b=BvXoALAdEB6UlrgVVlF9TF96cI uONDiGDkDchoLPqb7WcYkgFs5Q05vA405TxMNlzZuWLN0qnJfl/OCuiaBqawFDUEl15fduA7+8k5U BK70Lkt8q/q1eEz1Ugb2qyF5z; Received: from 174-29-48-143.hlrn.qwest.net ([174.29.48.143]:55406 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hhzyc-001ZrW-AF; Mon, 01 Jul 2019 12:20:26 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87ef3aq6ux.fsf@tromey.com> <5372d765-b75f-8d2c-bf0f-e3c0ddc3a802@redhat.com> Date: Mon, 01 Jul 2019 17:20:00 -0000 In-Reply-To: <5372d765-b75f-8d2c-bf0f-e3c0ddc3a802@redhat.com> (Pedro Alves's message of "Mon, 1 Jul 2019 13:37:53 +0100") Message-ID: <87muhxpt7q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00017.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> The visual balance of brackets is appealing as well, so I can't say Pedro> I have a strong preference either way. If you've been converting things Pedro> already, you'll have a better judgment, so I'll defer to you. I haven't really converted much, just what you saw on the branch. I suspect using some kind of paired brackets will make it a little harder to forget to close the style. But probably only a little. Also I guess we could add asserts to check that the closing parameter is always null. Pedro> If we went the always-%pS way, I had written the patch and it'd Pedro> look like this: This is fine by me too. Tom