From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51765 invoked by alias); 18 Sep 2019 16:18:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51757 invoked by uid 89); 18 Sep 2019 16:18:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2019 16:18:46 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 74E2C478D5 for ; Wed, 18 Sep 2019 11:18:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id AcfFisFdF4FKpAcfFisQFy; Wed, 18 Sep 2019 11:18:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DnR+NChUlIoIQwdpbQFJ6LEbzRFQLODyJ6Y+lEjkir8=; b=G0K6zq1c8f5w22QtOjrae3BG2b E4aBISwGrmwGY1x3rMntAfeesCfvs/Utb7Zq2wA48z9lErYFOtOgbQchLw/RjmyiRMHGSs7+iqFG8 xoDdZ0jxynEnqoYbolDj3edng; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:45094 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iAcfE-001ZMe-W7; Wed, 18 Sep 2019 11:18:45 -0500 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: remove local extern declaration of cli_styling References: <20190918030533.365417-1-simon.marchi@polymtl.ca> Date: Wed, 18 Sep 2019 16:18:00 -0000 In-Reply-To: <20190918030533.365417-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Tue, 17 Sep 2019 23:05:33 -0400") Message-ID: <87muf1tw64.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00344.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> * ui-file.c: Include cli/cli-style.h. Simon> (term_cli_styling): Remove cli_styling declaration. Thanks for doing this. I think as a rule it's best to always have declarations in a header and never in the .c code. That way they can be checked against the definition. Tom