From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91347 invoked by alias); 19 Feb 2020 21:01:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91275 invoked by uid 89); 19 Feb 2020 21:01:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=simon.marchi@efficios.com, HX-Languages-Length:711, simonmarchiefficioscom X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.195.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 21:01:07 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 3280B4100A811 for ; Wed, 19 Feb 2020 14:15:32 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4WSvjfw4nvBMd4WSvjdA4L; Wed, 19 Feb 2020 15:01:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9JBKPaUjOgklcsbWogwfNY3yMUSzcs424mhDXyFeuaw=; b=esmZDfBJjy3OAyeMYORtxoe7r6 8QPImvibNAOtsXqcNtzz+1CYrIYDjVOGCMRgsTD68kLXUUdwvYz2EbsvBlffHg42xlRZdM6iJkuOC wO0SEbnpEm3Jiobh9z+P/gNdl; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:54676 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j4WSv-002CLJ-3V; Wed, 19 Feb 2020 14:01:05 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: dwarf2/read.c: remove unused objfile parameters/variables References: <20200219205806.31097-1-simon.marchi@efficios.com> Date: Wed, 19 Feb 2020 21:01:00 -0000 In-Reply-To: <20200219205806.31097-1-simon.marchi@efficios.com> (Simon Marchi's message of "Wed, 19 Feb 2020 15:58:06 -0500") Message-ID: <87mu9es35b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00796.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> This is a simple cleanup. These functions used to use the objfile's Simon> obstack for allocation in the hash tables, but they don't anymore. Simon> Remove the unnecessary objfile parameters, which in turn allows removing Simon> some local variables. Simon> gdb/ChangeLog: Simon> * dwarf2/read.c (allocate_signatured_type_table, Simon> allocate_dwo_unit_table, allocate_type_unit_groups_table, Simon> allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table): Simon> Remove objfile parameter, update all callers. Looks good. Thanks for doing this. Tom