From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.51]) by sourceware.org (Postfix) with ESMTPS id 2A0F0385B834 for ; Tue, 31 Mar 2020 00:01:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A0F0385B834 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id BC6D5F97BDA for ; Mon, 30 Mar 2020 19:01:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id J4LQjDHkLSl8qJ4LQjjTdY; Mon, 30 Mar 2020 19:01:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OyWDubZSJxETVSKtz5ZuqMPhx7ZHGw60S2tDp6nwkSE=; b=weXgrnGfIcDC2fdLg6MQTbOdto HLtUoM/eiasZ0KdnBBbq1x/L6MyYvcQ1bkS4x/Ag4rE+t0CKu4AU9tDUzk/Udv87rHsY3oOSi3Fc9 /gAFbJzwmljrdUNhRW8xEzCT2; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:57122 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJ4LQ-00304p-HF; Mon, 30 Mar 2020 18:01:28 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 05/20] Remove some uses of DW_STRING_IS_CANONICAL References: <20200328192208.11324-1-tom@tromey.com> <20200328192208.11324-6-tom@tromey.com> <2f3698db-d6f3-ef0d-3d1e-ae0ef9e0ae45@simark.ca> X-Attribution: Tom Date: Mon, 30 Mar 2020 18:01:27 -0600 In-Reply-To: <2f3698db-d6f3-ef0d-3d1e-ae0ef9e0ae45@simark.ca> (Simon Marchi's message of "Mon, 30 Mar 2020 11:02:34 -0400") Message-ID: <87mu7xxui0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jJ4LQ-00304p-HF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (bapiya) [97.118.117.21]:57122 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 00:01:30 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> Would you be able to improve the documentation to say what is Simon> a "canonical string"? Yeah, I di dthis. Simon> If this is a DWARF concept and described Simon> in the DWARF spec, you could just refer to the relevant section Simon> of the standard too. Just FYI, it isn't; it is a gdb concept. Simon> Is this method only relevant if the attribute is of a string Simon> form? If so, the method name should perhaps still have "string" Simon> in its name, like "is_canonical_string" or "canonical_string_p". Done. Simon> I presume it doesn't make sense to call this method when the Simon> attribute has a non-string form, so should there be a gdb_assert Simon> that checks that the attribute has a string form? I had to move this to the next patch, since form_is_string doesn't exist yet. Tom