From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id CB307385DC02
 for <gdb-patches@sourceware.org>; Tue, 31 Mar 2020 19:35:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CB307385DC02
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id C42C8116982;
 Tue, 31 Mar 2020 15:35:10 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id yzFho32bN6i5; Tue, 31 Mar 2020 15:35:10 -0400 (EDT)
Received: from murgatroyd (97-118-117-21.hlrn.qwest.net [97.118.117.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id 661E411696A;
 Tue, 31 Mar 2020 15:35:10 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Avoid copying in lookup_name_info
References: <20200320204935.19509-1-tromey@adacore.com>
 <20200320204935.19509-3-tromey@adacore.com>
 <e71db8b2-3a4d-b57f-119f-24dafa675c74@redhat.com>
 <87wo70baqu.fsf@tromey.com> <87a73wbaji.fsf@tromey.com>
 <2f437216-b606-dc30-5775-478af47dbbaf@redhat.com>
X-Attribution: Tom
Date: Tue, 31 Mar 2020 13:35:09 -0600
In-Reply-To: <2f437216-b606-dc30-5775-478af47dbbaf@redhat.com> (Pedro Alves's
 message of "Tue, 31 Mar 2020 20:28:26 +0100")
Message-ID: <87mu7w9v2q.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 19:35:12 -0000

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Alternatively, you could delete the && version, like:

Pedro>   lookup_name_info (std::string &&name, ......) = delete;

Pedro> I think that would catch that case, making it fail to compile,
Pedro> forcing us to write:

Thanks for the idea.  I'll do this.

Tom