From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.55.25]) by sourceware.org (Postfix) with ESMTPS id 6157039484A4 for ; Thu, 18 Jun 2020 21:24:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6157039484A4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 7B2F8400CBF98 for ; Thu, 18 Jun 2020 15:04:37 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id m21fjqEodBb5dm21fj96HU; Thu, 18 Jun 2020 16:24:47 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WAnsY4xk2GGndfnpH1CVaOGSiSRK6gJPGGVTPluIkek=; b=lS5rnYNWz5SflbqD9tT5Sp6Apt +d1Abj/h4OuQKxKbSOJnHqOwYSgM1VmTWXKYl17XO1thz1JVJisFRh8nADGD1IFikeGBVQR0ZMwe0 j+LZQybKjesmf0u3UTGO9lFNW; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:57662 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jm21e-0045PZ-Q8; Thu, 18 Jun 2020 15:24:46 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] gdb/python: Add gdb.Architecture.registers method References: X-Attribution: Tom Date: Thu, 18 Jun 2020 15:24:45 -0600 In-Reply-To: (Andrew Burgess's message of "Wed, 17 Jun 2020 18:38:07 +0100") Message-ID: <87mu50ysma.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jm21e-0045PZ-Q8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:57662 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 21:24:48 -0000 >>>>> "Andrew" == Andrew Burgess writes: Thanks for doing this. Andrew> This commit adds a new method gdb.Architecture.registers that returns Andrew> an object of the new type gdb.RegisterDescriptorIterator. This Andrew> iterator returns objects of the new type gdb.RegisterDescriptor. Andrew> A RegisterDescriptor is not a way to read the value of a register, Andrew> this is already covered by Frame.read_register, a RegisterDescriptor Andrew> is simply a way to discover from Python, which registers are Andrew> available for a given architecture. Andrew> I did consider just returning a string, the name of each register, Andrew> instead of a RegisterDescriptor, however, I'm aware that it we don't Andrew> want to break the existing Python API in any way, so if I return just Andrew> a string now, but in the future we want more information about a Andrew> register then we would have to add a second API to get that Andrew> information. By going straight to a descriptor object now, it is easy Andrew> to add additional properties in the future should we wish to. Andrew> Right now the only property of a register that a user can access is Andrew> the name of the register. Andrew> In future we might want to be able to ask the register about is Andrew> register groups, or its type. This all seems reasonable. Andrew> +int Andrew> +gdbpy_initialize_registers (void) No need for "void" here in new code. Same in the .h. Looks good to me with those nits fixed. Tom