From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Rewrite valid-expr.h's internals in terms of the detection idiom (C++17/N4502)
Date: Mon, 28 Sep 2020 12:59:34 -0600 [thread overview]
Message-ID: <87mu19hgmh.fsf@tromey.com> (raw)
In-Reply-To: <20200821144523.19451-2-pedro@palves.net> (Pedro Alves's message of "Fri, 21 Aug 2020 15:45:21 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> + static_assert (gdb::is_detected_exact<EXPR_TYPE, \
Pedro> + archetype, TYPES>::value == VALID, \
Pedro> ""); \
I'm not sure if it was exactly this patch, but after I merged this code
to our internal tree, we started having build problems on a machine that
uses GCC 6.4. I've appended the error message.
I'm not sure it is worth doing anything about this, but I thought it
would be worth noting in case anybody else winds up in this situation.
Tom
../../src/gdb/unittests/offset-type-selftests.c: In substitution of 'template<class Expected, template<class ...> class Op, class ... Args> using is_detected_exact = std::is_same<Expected, typename gdb::detection_detail::detector<gdb::nonesuch, void, Op, Args ...>::type> [with Expected = selftests::offset_type::off_A&; Op = selftests::offset_type::check_valid_expr75::archetype; Args = {selftests::offset_type::off_A, selftests::offset_type::off_B}]':
../../src/gdb/unittests/offset-type-selftests.c:75:1: required from here
../../src/gdb/../gdbsupport/valid-expr.h:65:20: error: type/value mismatch at argument 2 in template parameter list for 'template<class Expected, template<class ...> class Op, class ... Args> using is_detected_exact = std::is_same<Expected, typename gdb::detection_detail::detector<gdb::nonesuch, void, Op, Args ...>::type>'
archetype, TYPES>::value == VALID, \
^
../../src/gdb/../gdbsupport/valid-expr.h:79:3: note: in expansion of macro 'CHECK_VALID_EXPR_INT'
CHECK_VALID_EXPR_INT (ESC_PARENS(typename T1, typename T2), \
^~~~~~~~~~~~~~~~~~~~
../../src/gdb/unittests/offset-type-selftests.c:42:3: note: in expansion of macro 'CHECK_VALID_EXPR_2'
CHECK_VALID_EXPR_2 (off_A, off_B, VALID, EXPR_TYPE, EXPR)
^~~~~~~~~~~~~~~~~~
../../src/gdb/unittests/offset-type-selftests.c:75:1: note: in expansion of macro 'CHECK_VALID'
CHECK_VALID (true, off_A&, lval_a += undrl {});
^~~~~~~~~~~
../../src/gdb/../gdbsupport/valid-expr.h:65:20: note: expected a class template, got 'selftests::offset_type::check_valid_expr75::archetype'
archetype, TYPES>::value == VALID, \
^
../../src/gdb/../gdbsupport/valid-expr.h:79:3: note: in expansion of macro 'CHECK_VALID_EXPR_INT'
CHECK_VALID_EXPR_INT (ESC_PARENS(typename T1, typename T2), \
^~~~~~~~~~~~~~~~~~~~
../../src/gdb/unittests/offset-type-selftests.c:42:3: note: in expansion of macro 'CHECK_VALID_EXPR_2'
CHECK_VALID_EXPR_2 (off_A, off_B, VALID, EXPR_TYPE, EXPR)
^~~~~~~~~~~~~~~~~~
../../src/gdb/unittests/offset-type-selftests.c:75:1: note: in expansion of macro 'CHECK_VALID'
CHECK_VALID (true, off_A&, lval_a += undrl {});
^~~~~~~~~~~
next prev parent reply other threads:[~2020-09-28 18:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 14:45 [PATCH 0/3] Rewrite enum_flags, add unit tests, fix problems Pedro Alves
2020-08-21 14:45 ` [PATCH 1/3] Rewrite valid-expr.h's internals in terms of the detection idiom (C++17/N4502) Pedro Alves
2020-09-28 18:59 ` Tom Tromey [this message]
2020-09-28 19:58 ` Luis Machado via Gdb-patches
2020-09-28 20:00 ` Tom Tromey
2020-09-29 13:04 ` Tom Tromey
2020-09-29 19:24 ` Pedro Alves
2020-09-29 22:50 ` [pushed] Tweak gdbsupport/valid-expr.h for GCC 6, fix build (Re: [PATCH 1/3] Rewrite valid-expr.h's internals in terms of the detection idiom (C++17/N4502)) Pedro Alves
2020-08-21 14:45 ` [PATCH 2/3] Use type_instance_flags more throughout Pedro Alves
2020-08-25 11:36 ` Luis Machado
2020-09-14 11:56 ` Pedro Alves
2020-08-26 10:06 ` Andrew Burgess
2020-09-14 12:54 ` Pedro Alves
2020-08-26 15:21 ` Andrew Burgess
2020-09-14 13:53 ` Pedro Alves
2020-09-11 20:21 ` Tom Tromey
2020-09-14 19:26 ` Pedro Alves
2020-08-21 14:45 ` [PATCH 3/3] Rewrite enum_flags, add unit tests, fix problems Pedro Alves
2020-08-21 15:51 ` [PATCH 0/3] " Andrew Burgess
2020-09-11 20:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu19hgmh.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox