Re: [PATCH 5/7] Close file handle of empty history file

Hannes Domani
2020-05-26T17:42:38Z

> Am Dienstag, 26. Mai 2020, 18:38:07 MESZ hat Christian Biesinger <cbiesinger@google.com> Folgendes geschrieben:
>
> On Mon, May 25, 2020 at 1:58 PM Hannes Domani via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
> >
> > Happened while trying to reproduce a gdb.base/gdbinit-history.exp failure:
> > warning: Could not rename C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history to C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history-gdb5228~: Permission denied
> >
> > I had an empty gdbinit-history.gdb_history-gdb5228~ file, and the file
> > handle was not closed on startup, so it couldn't rename it at the end
> > when trying to write a new one.
>
> Readline has an upstream repository, please send the patch to them as
> well at bug-readline@gnu.org.
> https://tiswww.case.edu/php/chet/readline/rltop.html
>
> Also add the change to readline/README per the instructions in there.
> Not sure if ChangeLog needs/should be updated.

Apparently, this was already fixed in readline master:
http://git.savannah.gnu.org/cgit/readline.git/commit/?id=f585708e822e021e15e5bece1de482b63ba581df

In that case I don't mind just leaving it as is, since it will be fixed
eventually anyways with the next update.

Hannes