From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4CokCLBUj1/IfQAAWB0awg (envelope-from ) for ; Tue, 20 Oct 2020 17:20:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 1F34F1EFC3; Tue, 20 Oct 2020 17:20:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AFE101EFBF for ; Tue, 20 Oct 2020 17:20:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5704039490A1; Tue, 20 Oct 2020 21:20:47 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.108]) by sourceware.org (Postfix) with ESMTPS id A601739490A1 for ; Tue, 20 Oct 2020 21:20:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A601739490A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 294F45244 for ; Tue, 20 Oct 2020 16:20:43 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Uz3jksQPbBD8bUz3jkontT; Tue, 20 Oct 2020 16:20:43 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=25veraQC7GogVWaeYVWCYA5wY325AZbxTT1owiwR6hs=; b=nsDLd6rIAdRYEEGG/Dg1WIXHdd 5JaNN2VFrsjql6NLktgUL4Y3jA9ieCZzSxeOaIcOX3iEYh1/TJkieBqqPuoV4VCycqSqK4pqlOvBd xeyRML3CFDv2g438NEMphGBg+; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:58366 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kUz3i-00106G-Rw; Tue, 20 Oct 2020 15:20:42 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH v2 07/16] Remove the exec_bfd macro References: <20201019214429.13815-1-tom@tromey.com> <20201019214429.13815-8-tom@tromey.com> <8c4c1ec0-cdc9-ebc9-26fa-216f59493d9b@simark.ca> X-Attribution: Tom Date: Tue, 20 Oct 2020 15:20:42 -0600 In-Reply-To: <8c4c1ec0-cdc9-ebc9-26fa-216f59493d9b@simark.ca> (Simon Marchi's message of "Tue, 20 Oct 2020 10:24:56 -0400") Message-ID: <87mu0gd26t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kUz3i-00106G-Rw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (bapiya) [75.166.102.113]:58366 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Simon> Maybe just check for lines that are too long after the replacement. Will do. >> - add_target_sections (&exec_bfd, sections); >> + add_target_sections (¤t_program_space->ebfd, sections); Simon> It's odd that the owner of these sections is the address of the ebfd Simon> field in the program_space structure, and not the bfd pointer itself. Simon> Do you know if this is done on purpose? There's probably no good reason for it, though I'm not completely sure. Simon> I don't see anything that could change the value of exec bfd in the mean Simon> time, that would make the "owner" value of these sections stale. So I Simon> believe it would be safe to use `current_program_space->exec_bfd ()` as Simon> the owner. Or even just the program space itself. The value is really just a cookie to make sure that different callers don't accidentally clash. Tom