Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
	Shahab Vahedi <shahab@synopsys.com>
Subject: Re: [PATCH] arc: Fix gcc-4.8 compilation failure for arc.c
Date: Tue, 09 Feb 2021 07:52:42 -0700	[thread overview]
Message-ID: <87mtwdcmyt.fsf@tromey.com> (raw)
In-Reply-To: <20210209091209.7363-1-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Tue, 9 Feb 2021 10:12:09 +0100")

Shahab>    target_desc *tdesc = arc_create_target_description (features);
 
Shahab> -  /* Add the newly created target description to the repertoire.  */
Shahab> -  arc_tdesc_cache.emplace (features, tdesc);
Shahab> +  /* Add the newly created target description to the repertoire.
Shahab> +     PR build/27385: Use "target_desc_up ()" ctor explicitly.  */
Shahab> +  arc_tdesc_cache.emplace (features, target_desc_up (tdesc));
 
Shahab>    return tdesc;

I was going to suggest that arc_create_target_description return a
target_desc_up, but when I look at the code, I see it already does, and
that this line is different:

  arc_tdesc_cache.emplace (features, std::move (tdesc));

So I suspect this is already fixed.

Tom

  reply	other threads:[~2021-02-09 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09  9:12 Shahab Vahedi via Gdb-patches
2021-02-09 14:52 ` Tom Tromey [this message]
2021-02-09 17:03   ` Shahab Vahedi via Gdb-patches
2021-02-09 17:11     ` Tom Tromey
2021-02-09 17:41 ` [PUSHED gdb-10-branch] " Shahab Vahedi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtwdcmyt.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=shahab.vahedi@gmail.com \
    --cc=shahab@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox