From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6GxCO4svI2DRcAAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 19:57:47 -0500 Received: by simark.ca (Postfix, from userid 112) id F0AF61EF4F; Tue, 9 Feb 2021 19:57:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9FF501E789 for ; Tue, 9 Feb 2021 19:57:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FD86386F035; Wed, 10 Feb 2021 00:57:47 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.172]) by sourceware.org (Postfix) with ESMTPS id 7808E3857830 for ; Wed, 10 Feb 2021 00:57:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7808E3857830 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 165C11D81A for ; Tue, 9 Feb 2021 18:57:45 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9dpBl2Cgbsvw99dpBl6vIl; Tue, 09 Feb 2021 18:57:45 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z76LK8WBt5djj2wB9AMZIgmtLNfCx5md8Ve/TP6HAWA=; b=GVrCkCtCqLtj84H9pu+4A4+P5U JlkWmoonJD0+bYFTrEVtuXNoGjAIKdcMbhrPjYbjiYhJabkghGEWxBV0/4DKzdCF4pXlcxLtOpxsJ L060WMIMMmh/5czh6c7WrAF6D; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:43948 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9dpA-001u8n-Qm; Tue, 09 Feb 2021 17:57:44 -0700 From: Tom Tromey To: Lancelot SIX via Gdb-patches Subject: Re: [PATCH 073/203] Introduce class operation References: <20210101214723.1784144-1-tom@tromey.com> <20210101214723.1784144-74-tom@tromey.com> <20210103070912.GA363503@adacore.com> X-Attribution: Tom Date: Tue, 09 Feb 2021 17:57:44 -0700 In-Reply-To: (Lancelot SIX via Gdb-patches's message of "Sun, 3 Jan 2021 13:55:46 +0000") Message-ID: <87mtwcrb7b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9dpA-001u8n-Qm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:43948 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , Lancelot SIX , Joel Brobecker Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>> +typedef std::unique_ptr operation_up; >> FWIW, the connection between "up" and the rest of the declaration >> wasn't immediately obvious to me. I think this is because "up" >> is an english word, and spelled like that, all in lowercase, >> that's really what my brain keeps analyzing it as first. It takes >> an effort to adjust my thinking against this bias. Lancelot> I am fairly new to this codebase, but as far as I can say, this sort Lancelot> of naming convention (the _up suffix for a typedefed std::unique_ptr) Lancelot> is already used here and there: Lancelot> $ git grep 'typedef std::unique_ptr.*_up;'|wc -l Lancelot> 33 Lancelot> I have to admin that the first time I came across it it was not Lancelot> obvious to me either, but it would make sense to keep it this way for Lancelot> consistency (I guess). Yeah, IIRC the "_up" suffix (for "unique pointer") was introduced a while back by Pedro; this is just following the existing naming convention. Tom