From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OTdsNARTcGFfLAAAWB0awg (envelope-from ) for ; Wed, 20 Oct 2021 13:33:56 -0400 Received: by simark.ca (Postfix, from userid 112) id C3A281F0BD; Wed, 20 Oct 2021 13:33:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0EC721E79C for ; Wed, 20 Oct 2021 13:33:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 991663858030 for ; Wed, 20 Oct 2021 17:33:55 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.233]) by sourceware.org (Postfix) with ESMTPS id 8B6453858C3A for ; Wed, 20 Oct 2021 17:33:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B6453858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id A5E8B1AACB for ; Wed, 20 Oct 2021 12:33:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dFTCm7j5qG0jLdFTCmBrGV; Wed, 20 Oct 2021 12:33:42 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pMDh/gBEmdYrpdFhxet8HvhLRnkS+tCP8Fru8d6BEZc=; b=TbQaglbE9+GE1uMYvXpXlmbMjX +W8trcETQL/4nXdVCyWoeViOU55qkKwNfHEo+MFdWvT2vfep5rzMXm90GK1ubkltTvK2/lrQjIgJg TgWjdP46SvrEND14CHA6WPTnv; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54014 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mdFTC-000KWN-45; Wed, 20 Oct 2021 11:33:42 -0600 From: Tom Tromey To: Stafford Horne via Gdb-patches Subject: Re: [PATCH 1/5] gdb: or1k: implement gdb server References: <20210913124800.471680-1-shorne@gmail.com> <20210913124800.471680-2-shorne@gmail.com> X-Attribution: Tom Date: Wed, 20 Oct 2021 11:33:41 -0600 In-Reply-To: <20210913124800.471680-2-shorne@gmail.com> (Stafford Horne via Gdb-patches's message of "Mon, 13 Sep 2021 21:47:56 +0900") Message-ID: <87mtn3vbwq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mdFTC-000KWN-45 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54014 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Openrisc Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> ">" == Stafford Horne via Gdb-patches writes: >> This patch adds gdbserver support for OpenRISC. This has been used for >> debugging the glibc port that in being worked on here: >> https://github.com/openrisc/or1k-glibc/tree/or1k-port-2 >> Hence the comment about registers definitions being inline with glibc. Thanks for the patch. I had one minor comment. >> +#define or1k_breakpoint_len 4 >> +bool >> +or1k_target::low_breakpoint_at (CORE_ADDR where) >> +{ >> + unsigned int insn; >> + >> + read_memory (where, (unsigned char *) &insn, 4); Perhaps this ought to use or1k_breakpoint_len here. >> +/* Fetch the thread-local storage pointer for libthread_db. */ >> + >> +ps_err_e >> +ps_get_thread_area (struct ps_prochandle *ph, >> + lwpid_t lwpid, int idx, void **base) >> +{ Not your problem but it seems like a shame that this exact implementation is repeated several times in gdbserver. Tom