From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9XfxJjDA2WEHXwAAWB0awg (envelope-from ) for ; Sat, 08 Jan 2022 11:47:44 -0500 Received: by simark.ca (Postfix, from userid 112) id 89D8C1EE1A; Sat, 8 Jan 2022 11:47:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B84A21EA69 for ; Sat, 8 Jan 2022 11:47:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6CA3385ED40 for ; Sat, 8 Jan 2022 16:47:42 +0000 (GMT) Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id BD42F385E838 for ; Sat, 8 Jan 2022 16:47:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD42F385E838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 28D8910048470 for ; Sat, 8 Jan 2022 16:47:31 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 6EsMneysInAlU6EsNnVRal; Sat, 08 Jan 2022 16:47:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=61d9c023 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=UYHlwHiTjc3C2c1SVOwA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=M4TYVHLZAcQsOeRnB7W0ogH8mE/oZ+jdD4bo2yii8KY=; b=vRpsKv0hdZaYKN3/72vmHxNONm VfcTQpt4XdqZYgpUSjXTOsO5aRrj6Z965UXSaxgQoKMV8EhjzS9H4VmLcjfgTQOFE0OjSnpuZOWE6 OJvobHoHlyRSS0qQ6SCkL81J/; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:40648 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n6EsM-0009Qc-9J; Sat, 08 Jan 2022 09:47:30 -0700 From: Tom Tromey To: Lancelot SIX Subject: Re: [PATCH 1/2] Introduce target_announce_attach References: <20220105175916.2969966-1-tom@tromey.com> <20220105175916.2969966-2-tom@tromey.com> <20220108150641.eefdfocex34schl7@Plymouth> X-Attribution: Tom Date: Sat, 08 Jan 2022 09:47:29 -0700 In-Reply-To: <20220108150641.eefdfocex34schl7@Plymouth> (Lancelot SIX's message of "Sat, 8 Jan 2022 15:07:06 +0000") Message-ID: <87mtk65g4e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n6EsM-0009Qc-9J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (prentzel) [75.166.134.30]:40648 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Lancelot> Just a nit, and I know you just moved this bit of code around, but Lancelot> shouldn't this become Lancelot> if (exec_file != nullptr) Lancelot> ? Yes, thanks. I'll send a patch to fix it shortly. Tom