From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Cal7DSNT0GLc1xIAWB0awg (envelope-from ) for ; Thu, 14 Jul 2022 13:32:19 -0400 Received: by simark.ca (Postfix, from userid 112) id 279261E5EA; Thu, 14 Jul 2022 13:32:19 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=OVFWtW4b; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38F281E222 for ; Thu, 14 Jul 2022 13:32:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7CA33858D37 for ; Thu, 14 Jul 2022 17:32:17 +0000 (GMT) Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 826CB3858D1E for ; Thu, 14 Jul 2022 17:32:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 826CB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 5376B1003FB9A for ; Thu, 14 Jul 2022 17:31:54 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id C2growvZBq24iC2gsozDhS; Thu, 14 Jul 2022 17:31:54 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DaLSFthW c=1 sm=1 tr=0 ts=62d0530a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=sj9rAXlmZhbrYuBfWP0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=le2PSpqHOQVzy0rA7NvJNllM5hzTlWGIXyZOu2zi8KA=; b=OVFWtW4bWVwqBP6du3dLAWFXo/ tsByv193IHU7SQSqpjMOthGwKH83IeKUxUa0x9x5jPOBALnGxxJxY7Wi0+GCx0P5HD2GtzvksmXNV AP7BC7dD0tJ6EnkQOGSWamkwD; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56066 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oC2gr-0029FB-Ha; Thu, 14 Jul 2022 11:31:53 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [committed][gdb/symtab] Fix data race in ~charset_vector References: <20220714061923.GA543@delia.home> X-Attribution: Tom Date: Thu, 14 Jul 2022 11:31:52 -0600 In-Reply-To: <20220714061923.GA543@delia.home> (Tom de Vries via Gdb-patches's message of "Thu, 14 Jul 2022 08:19:25 +0200") Message-ID: <87mtdbsirb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oC2gr-0029FB-Ha X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56066 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The problem is that we're freeing the charset_vector elements in the destructor, Tom> which may still be used by a worker thread. Could you say how this happens? What is the worker thread doing? Normally I think gdb should be waiting for background tasks to finish before proceeding with this sort of destruction. If this is coming from the parallel DWARF reader, maybe we need some higher level API to cleanly shut down those threads first. Tom