From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id v7yBB9LapmSj/RcAWB0awg (envelope-from ) for ; Thu, 06 Jul 2023 11:16:34 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Huk/aq07; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F2F331E0BD; Thu, 6 Jul 2023 11:16:33 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CDE8A1E00F for ; Thu, 6 Jul 2023 11:16:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E4B138560B9 for ; Thu, 6 Jul 2023 15:16:31 +0000 (GMT) Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id D78CD3858C74 for ; Thu, 6 Jul 2023 15:16:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D78CD3858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 2B0BC10044F5E for ; Thu, 6 Jul 2023 15:16:07 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id HQiEqcGEAef6tHQiEq0CS9; Thu, 06 Jul 2023 15:16:07 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=efT4w5IH c=1 sm=1 tr=0 ts=64a6dab7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zOKFhozi0gO1G-oyvHsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7S08Bv7cI0DVbYktKkB1NzWs1kav3bj+RrwFICWydJ8=; b=Huk/aq07jTRvOAGHknxJFa3IS6 9Bd+TB4jX+kyB6RPfno7iBwpSqmBJ/UysR09dJ+j+5B1XC2nJV0OCMkhXUlFttWDt/w1UL3EXkthQ YFe0kssILElB3NsCFQsQy+hgS; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:58870 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qHQiD-003kZ7-33; Thu, 06 Jul 2023 09:16:05 -0600 From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Tom Tromey , Simon Farre Subject: Re: [PATCH v1] gdb/DAP - Add completionsRequest References: <20230628162616.102268-1-simon.farre.cx@gmail.com> <874jmkx11c.fsf@tromey.com> <79d036ac-81f5-ee9b-233c-0b2f6f5a0f11@gmail.com> X-Attribution: Tom Date: Thu, 06 Jul 2023 09:16:03 -0600 In-Reply-To: <79d036ac-81f5-ee9b-233c-0b2f6f5a0f11@gmail.com> (Simon Farre via Gdb-patches's message of "Wed, 5 Jul 2023 16:02:02 +0200") Message-ID: <87mt09ul3g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qHQiD-003kZ7-33 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:58870 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Farre via Gdb-patches writes: >> Since 'line' isn't used, I think it can just be removed here and also >> from 'completions' itself, as it is optional anyway. Simon> Right, I added it to make it look 1-to-1 with the DAP spec, _even Simon> though_ we don't actually use them in GDB, Simon> as I find this approach less confusing - if a GDB contributor (or Simon> user) were to look up the signature, then look at the DAP spec Simon> and not see the same things. But I'll remove the things that doesn't Simon> make sense, as it were, in GDB-land in the next patch. For the DAP side (the @request) this is arguable but also fine. I personally think it's clearer to only name parameters that are actually used, but if you want to do it that way, I'll approve it. On the gdb side (@in_gdb_thread) I think it's better to only accept things that are actually used. It's also arguably better here to do any needed pre-processing in the DAP thread. thanks, Tom