From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Mp11AbYwAGc7VgEAWB0awg (envelope-from ) for ; Fri, 04 Oct 2024 14:15:18 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=igcmPa0e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E016B1E355; Fri, 4 Oct 2024 14:15:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16FCC1E05C for ; Fri, 4 Oct 2024 14:15:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77EF9385E827 for ; Fri, 4 Oct 2024 18:15:16 +0000 (GMT) Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id CE01F385C6E3 for ; Fri, 4 Oct 2024 18:14:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE01F385C6E3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CE01F385C6E3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728065700; cv=none; b=whmM6EI00QN6dJzyrj+wP/VwrS/gEqr6LK/30BJUbF1rSNwdSSpMdM/L/lUbjyBYs2L2BaEMA+nMTpHYgFJ0RQYMQ4K5eJwHQpff43b6n9pPnBIv3a3yPHxYOGDAqNEoEQX6VXrjbclH+ASOOv71ZPn2JtrR40EE4TPzC2T0rhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728065700; c=relaxed/simple; bh=afe4MQ4P+qqpIHbpjxI8QwvlIjj56pYKQ2A/tbzKHaI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=a5qLDuVna7jYHa2VNxLbfioC4kdnoYs+QGHOJ0n+P/TijSkL2+iF+wuscbcUxG5HRfI0rsSOHhpTwqCHuWyyYWShYZdTx+NvBQ5VlD/+o1HVzd8xYHqE2TNjF9l9gR0YuXmuqq++p67k6UOpLrp7YyKkYqrgtAXdBt+ryYQ6DFA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id wlBwsiUA91zuHwmpOsYAB4; Fri, 04 Oct 2024 18:14:58 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wmpNscPM4ky5UwmpOs8A1s; Fri, 04 Oct 2024 18:14:58 +0000 X-Authority-Analysis: v=2.4 cv=Cum5cG4D c=1 sm=1 tr=0 ts=670030a2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=DAUX931o1VcA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=zstS-IiYAAAA:8 a=Aux37edtdGn2xUD6Fw8A:9 a=3IwEQjCEw6MA:10 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WxRJGO/eYEIK6xpHnKs2yNNMgUd8zkQk6pz3QWy+h1w=; b=igcmPa0eKAPrSqS3woFDoBkCZ3 agcknDvcNYTL3FbXMUtuVkhaanlLJqb84qgklOWj9pbJ09xqsnWtkvMY3f9yhjmGhf/vTfRvvm92H zaRPfXBFIaUbjqOto+gbGZ2y6; Received: from 97-122-122-36.hlrn.qwest.net ([97.122.122.36]:59334 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1swmpN-002L4W-1I; Fri, 04 Oct 2024 12:14:57 -0600 From: Tom Tromey To: Gaius Mulley Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/m2: add builtin procedure function ADR In-Reply-To: <87o73zq4fi.fsf_-_@localhost> (Gaius Mulley's message of "Fri, 04 Oct 2024 16:21:53 +0100") References: <875xq8x90o.fsf@localhost> <87v7y8ge0f.fsf@tromey.com> <87o73zq4fi.fsf_-_@localhost> X-Attribution: Tom Date: Fri, 04 Oct 2024 12:14:56 -0600 Message-ID: <87msjjhh0f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.36 X-Source-L: No X-Exim-ID: 1swmpN-002L4W-1I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-36.hlrn.qwest.net (murgatroyd) [97.122.122.36]:59334 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIlsaWABKPKoh0hWyV4pNCZfB+XXK/sSFHyg4wEthLv6tniu3fnVd+dpWfIKS2DKgrgsHT5jCkd0wrbAacl1hGnM8DpMhcjJ7XdCyN9GPEy+HCAkNKRn Od8k14rIP8Kb8JGBcPCJ2QlsOaG/e90gDPcaSsoI7gqOUYO3FRIPEfG0g+1FHIwQ/bKzwT+RcVO6pd4kGMaV0cQBgAO+V5o67PA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Gaius" == Gaius Mulley writes: Gaius> Many thanks for the review, here is v2 with a testcase. In v2 the only Gaius> change is the new file gdb/testsuite/gdb.modula2/builtin-procedure-adr.exp. Looks good to me. Thank you. Approved-By: Tom Tromey Tom