From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SDX9Fg5kBmfqTQcAWB0awg (envelope-from ) for ; Wed, 09 Oct 2024 07:07:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZqKxFXRv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 584FC1E354; Wed, 9 Oct 2024 07:07:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9FD581E354 for ; Wed, 9 Oct 2024 07:07:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F1EE2384DD00 for ; Wed, 9 Oct 2024 11:07:56 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D4C71385DC1E for ; Wed, 9 Oct 2024 11:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4C71385DC1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4C71385DC1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728472059; cv=none; b=TqYOLP5WL5GE/u3mxZIFyaVzI8cHkdz0AVfbMP+s6Bl4R7D5HAWU5lHQVf13u8lk/pJ6UNjoIVCDN1bpwwQbG4FoqtAI6lU58Dgq5Y4dnODbygQhp6Mc2sF4QK653xi3k1Oogfsg5IHBMCsFzXgHrL9/CnRhH4daXV9eVpn9OLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728472059; c=relaxed/simple; bh=sV2kyq6QU3AjkBLGVIbh6yt6xnaP/bEMLWM/8Xf0bas=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HW391MQ20LuA3OAVQyAsmsVj5MpZnD80AUMSaLKBOYuP5YgJaE4qzXkr2FS2AlECzMKQZde83bZDSvTsXFVkk08MKD6I3QRzPbTRARyzN/F2E9QJRyYEi1D4Cr+MUaZcpU9djhrp5WPDycIqRvV+YwnEc0Bav9a6ripj9xSNzG0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728472057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+XKA3ecP+GFjeGg66vhfkg0YSyzj71UxlQKeN9I3sqw=; b=ZqKxFXRvcb9D1OaacXYD9IZX/lXvP2F+JFsAz1qSqZaNlgIf4M1tBLuRuZN8veVobAQ0GK OItg6GXz/vmJu/VXh7UgxV20YHrfjMq4Mx8o1J6NXwJbzhUh67I1rCNBbep7SHWBiRsaaG 3dzMrcwAVB5o4IyFEPa5O8kBQ7UDxmE= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-ahuQhb8aOP-gIzx7Apyikg-1; Wed, 09 Oct 2024 07:07:36 -0400 X-MC-Unique: ahuQhb8aOP-gIzx7Apyikg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a995056fadcso255603166b.1 for ; Wed, 09 Oct 2024 04:07:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728472055; x=1729076855; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+XKA3ecP+GFjeGg66vhfkg0YSyzj71UxlQKeN9I3sqw=; b=tchQGyLvh1ifW8dyNNlhkK/GwqQdU8A/1O5/K+V4Nn9Vpp/AXZ1TZjbkDtdd8Wn0vm xSJbegLLOl/6NLVcYoAnDmVhjgyAlN7urSIVU62tsFNKX3mFqn5Tw7hfzKjoMFC4pE9t 9luM9CfOhBDTUVL24Z3a9QlEKLRi0vTV58uGQvV7W1Qs0lYsEnCjyYspe6MXX8Gnc9jP LZrHQlzsir/lcbGH2ZZamtUsfpblXbxDuM04ltGmHkmZ7ye1r8+Dhe0SbWHGqWT4SAvs YczcNc5VHGrfXwF+MH6uIMyRgEv4I6NXAbgUJUdm6JuFcsvdJ/WRhoOonOngTD3SMamh Uc8A== X-Forwarded-Encrypted: i=1; AJvYcCVZv5GAZ6KsAIC0CDM/O78mtTSCX8pVIrRG++75jC90ngM5rR3SwLrkVRzCbQrkRAYgOYiXR6nUBm3pgg==@sourceware.org X-Gm-Message-State: AOJu0YwJlgH7yPzYf49J28QwVCE8ULPNAnzo5thvk4jlVPo2IR4O1msD WYRQnFXRrHVR4JBdoign0FVLKyO3myxA6N0EShbH3lKZseqr3n/rJz3/G3TOsPXek7pMdKeG5Aq QppvxpQJxnDNhPnaFUa+JvkpJNV9WEwVnQ02A4AE+vygwcO5LXTDiI8BUaOFIQydZIXY= X-Received: by 2002:a17:907:f1a9:b0:a99:6345:7219 with SMTP id a640c23a62f3a-a998d216a77mr181185066b.29.1728472054735; Wed, 09 Oct 2024 04:07:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJlaUGHsOSbq6VmNNJGVcwXVl+KgUnit8rMAv1F+q/Wp92YY3kg16/Zy7fHytZuUkTRzyC7Q== X-Received: by 2002:a17:907:f1a9:b0:a99:6345:7219 with SMTP id a640c23a62f3a-a998d216a77mr181183466b.29.1728472054269; Wed, 09 Oct 2024 04:07:34 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99482270c5sm499642466b.184.2024.10.09.04.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:07:34 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr In-Reply-To: References: Date: Wed, 09 Oct 2024 12:07:33 +0100 Message-ID: <87msjdbklm.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2024-10-06 14:37, Andrew Burgess wrote: >> Convert target_desc::arch and target_desc::osabi from 'const char*' to >> gdb::unique_xmalloc_ptr. This also allows us to remove the user >> defined ~target_desc destructor. >> >> I doubt it ever actually occurred, but in theory at least, there was a >> memory leak in set_tdesc_architecture and set_tdesc_osabi where the >> member variables were assigned without freeing any previous >> value... but I suspect that usually these fields are only set once. >> >> There should be no user visible changes after this commit. > > Could they be std::string instead? I considered this, but that would, I think, require wider reaching changes as the API to add the osabi to the returned tdesc passes the information via 'const char *'. This approach added the memory safety without requiring any further changes. If you'd prefer std::string be used then let me know and I'll update things. Thanks, Andrew