From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mwtiNVaQoWd3yCMAWB0awg (envelope-from ) for ; Mon, 03 Feb 2025 22:58:14 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fea6IqA1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C74151E105; Mon, 3 Feb 2025 22:58:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1772E1E05C for ; Mon, 3 Feb 2025 22:58:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2F703858C35 for ; Tue, 4 Feb 2025 03:58:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2F703858C35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fea6IqA1 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 244033858D20 for ; Tue, 4 Feb 2025 03:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 244033858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 244033858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738641463; cv=none; b=J29iqvP0tJhpLQaFOwX/r9ipbjkNVW9Que6gGnWIzJoVJbStsyFo2SfWc8GnJmTxWHUegE4MHiTmH78gT3+1f5v35ZhH++eehsDM3rd8P7nS13XMsl6gtrbJBRWWyTNgqIoDCKePJkcpbzJZ1CEKBS7flF/pUprB6Ebh2ivVZGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738641463; c=relaxed/simple; bh=lpNiyu+xOKuSDATsDT7O/w8gaLBwl0N/rpw9vAWOrZY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fpu2TXHVe1wNk4sEqNPLrIsN1U5LfUWcei0YQygDC9LTdkKw/5ISaIIQHhJMSJHuv7Fwr12g4Y2X2vh+VFGfQAbkWpwV47IU1iJFJk2XdQbb8xgPoXClu+ZjMU3GGq6bcB+zKeZx47K8gUPuWb/bZuUF7TIo/FMZ4HjZ7VMTw40= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 244033858D20 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-21ddab8800bso71628535ad.3 for ; Mon, 03 Feb 2025 19:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738641462; x=1739246262; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q/tAI2y6PGXZwzB0yf8AVVPrDi/m32bbFnT7Cz6jNVQ=; b=fea6IqA1rvyfLY20/hYhg6+Z35qn2y1Zo93hgqot46yX45Nm/4UkJm2lZIIQcBKSsc Y5QtWXvR357jPE9rsUjH5cLp8KMh/esiSOI+aVhWNNYMqWP9QgYsodNa0gGFZWC7ubOr ENaMRLaK9O6P/xvA0N9jtLDfXxFFOQMlO/24JJ1FNQ3xNDMGxrtdcphzOji0QT+9Rv3h JCgc9BxztOGvt3PZM4vbXxfSW7p8Zey3j+pfRVPO4TdgPz0sdnUh/fZ0FT85Bq/a48bg y0aMCMSW23v3MwyH0+/3d2ryPRtCG4YZhijkpWDrxuvRfpQvZ8PLjUZoPffyDHEsBan6 McdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738641462; x=1739246262; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q/tAI2y6PGXZwzB0yf8AVVPrDi/m32bbFnT7Cz6jNVQ=; b=uQM8ykECPd8bm4zasi3QrkA/IPWgQVXC82Y30lvdzd9X7VctVQu3Rg4TsOO0r0rKap F4bAi0Iklx9zcvoFS3dOtYmdczeuRCOHy4k0dNrfIbmhRCwmfABHBnSqv5rFFdY1WccH Lq1Yl7yCltFah3W/zLP8qFjvA7W+JbfvSxeKYQxOmfUWbV4NlhSqCqbeGoxE/e26XCtU DemXYLO83gwcuwMXSElq4zQwRnBGJNNBG9Q1VtZ5fEDmKXYp6T+uCuLXFxIZLW3IqIjL Ulhd1HJ722MZL8cZmNTjjVecXytLJrACyQ0yXG84Ud8yLQlrPI+yOkq5ZDp9fZBNI02d 9HBw== X-Forwarded-Encrypted: i=1; AJvYcCUPIK3zVSAfcUW7CmmyioCMel65DmezivN7KsHYCzM96w5rPwVkK2DYEwyzILw91C+QcQ4RyIT12D2l9Q==@sourceware.org X-Gm-Message-State: AOJu0YxSMpKsunfNT9B9zhRyK81VkUpA4TzPPjzVaBs3MmJnqtJeNIno ixSTkK9sg30HYY/ila4GDBev+NsbgI7277kb/qdnErrp2Zq7AVtR8FkwbVhitbQ= X-Gm-Gg: ASbGncvm/VymsSWyYgMNwOAGrGmbZt2AWmdRnMA5FbeIvEJRS0pQHeRQOwhm0z2DHIa LwqoNb8i8/kO6bDkVF4COqgGFueJB+P7vdYRAutgiQHOBQGF/wPK4tgN5ni0onNzdiAzEoA/XPQ N0IMlDCbAHx00CW87ZhnCyZvEsN32djwaRNMWIEYBZm0I+T5e79dZL9I0AUgu2jIQefvJeaVdfC M/O/+1dPCZmQEnhnjoTrb2a41uKaZF8cmw4WDNtrB7y65sJUzjzqpts8oi5wdOBuO/T2SR/LNRr 8tTVzp3HcXUavrp3ivatWWcO X-Google-Smtp-Source: AGHT+IHJtsMI8xuOzF5rAFEE5jHIsnplbl67sFVZmbTHU6yx4kpC22m9nBp/4Gq+O8J5XHAXkvc8Lw== X-Received: by 2002:a17:902:ce8f:b0:215:9d29:9724 with SMTP id d9443c01a7336-21dd7ddfdc9mr414578385ad.38.1738641462075; Mon, 03 Feb 2025 19:57:42 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:5b30:74de:d8e5:608]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f06e72c27sm1420565ad.114.2025.02.03.19.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 19:57:41 -0800 (PST) From: Thiago Jung Bauermann To: "Schimpe, Christina" Cc: Guinevere Larsen , "gdb-patches@sourceware.org" Subject: Re: [PATCH 00/12] Add CET shadow stack support In-Reply-To: (Christina Schimpe's message of "Thu, 30 Jan 2025 17:46:40 +0000") References: <20241220200501.324191-1-christina.schimpe@intel.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Tue, 04 Feb 2025 00:57:38 -0300 Message-ID: <87msf2s6od.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Christina, "Schimpe, Christina" writes: >> -----Original Message----- >> From: Guinevere Larsen >> Sent: Thursday, January 30, 2025 4:01 PM >> To: Schimpe, Christina ; gdb- >> patches@sourceware.org >> Subject: Re: [PATCH 00/12] Add CET shadow stack support >> >> On 12/20/24 5:04 PM, Schimpe, Christina wrote: >> > Hi all, >> > >> > this is a series to add amd64 shadow stack support to GDB on linux. >> > Shadow stack is part of the Control-flow Enforcement Technology (CET) >> > by Intel. >> > >> > Intel's CET provides the two capabilities to defend against >> > ROP/COP/JOP style control-flow subversion attacks: shadow stack and >> > indirect branch tracking (IBT). >> > >> > While there is linux kernel support for CET shadow stack in userspace, >> > there is no linux kernel support available for userspace IBT, yet. >> > This series therefore focuses on CET shadow stack only. >> > >> > I am looking forward to your feedback! >> >> Hi Christina, thanks for the incredible work in this series! >> >> I looked over all the patches, and sent all my comments inlined, the other patches >> look alright to me. I don't know if I understand enough of the code to give a >> review tag, and I don't have a machine with shadow stack support to test the >> series, so I hope this series gets some attention from global maintainers soon, I'd >> love to see this work merged! > > Hi Guinivere, > > Thanks a lot for looking at this ! > > My plan is to wait until I receive bit more feedback for this series > and until patch #1 is merged, which I posted now separately. I'm almost finished reviewing this patch series. I think I'll be able to send some review comments tomorrow. In the meantime, one question: do you still plan to add a "bt -shadow" command, or any other shadow stack related command as discussed in the thread below? https://inbox.sourceware.org/gdb/SN7PR11MB7638DE1337F8F0F0282EBD56F996A@SN7PR11MB7638.namprd11.prod.outlook.com/ I ask because for AArch64 Guarded Control Stack (which is equivalent to Intel Shadow Stack) I'll need to add commands to enable/disable shadow stacks, and also to see which GCS-specific features are enabled and locked in the inferior. -- Thiago