From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dyYEDTK3D2iclwoAWB0awg (envelope-from ) for ; Mon, 28 Apr 2025 13:13:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dEszPu06; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 264A81E10E; Mon, 28 Apr 2025 13:13:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC2A01E0C0 for ; Mon, 28 Apr 2025 13:13:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4853E385840B for ; Mon, 28 Apr 2025 17:13:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4853E385840B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dEszPu06 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1CE173858C60 for ; Mon, 28 Apr 2025 17:12:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CE173858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CE173858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745860342; cv=none; b=m5/dKA1gIgcU1cEaS2vyP1+52mC5HcpQ1nwTqEFGgfLNGQI9WHPKC+jbtkt5xi+E3/Wki/dA8JLkn9vaIIaGiEPI1aILiuuPcKSvpN1ThR/MwyWOOIpQ2yd2dcGxV04IRcTWruEHnfk83CDjQb6svjq0neohmvA2CQwSs/0gmfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745860342; c=relaxed/simple; bh=e9nl322WK9XVTJ+YdYkghBeJuEzhJRNWy+EmY0uoPeo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=D0z6ucUPAsH5IG4TSw/jJvqtO/CuLSmPTkJDDEDu4Qg/WLS9YLa7uMdweWrBxlxmqlC0WmSs89ZniNksMkDXIVxd5W3TXGJYbncd2YmtCJ8ANy00tDjslwonDQRzy0fB4fK7DDB/FReg/2hIU721iVWTnZfxOQFaDx6B3KOlvE4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CE173858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745860341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=12QvVqLXlGs5CmweSckIByUDZ+ahkk4NQsvXAkhd9vo=; b=dEszPu06pYaUUZ9aDT+ZrtPyq9E26agDBSsPtHnxXFDXaP9dDDzJfIumRPJYt2u23cKuyY 1gJignz3H0Ml2Y4T2A/C/iUonjxNkbzAWyKTucY2xqHwRpcEwaqNAh9nqfiqGi4ykImUhd 546Tfya+cT7ZZOkQ3FgchZabhe94DfU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-v7G_8dPdPqKci2i7TFObCQ-1; Mon, 28 Apr 2025 13:12:20 -0400 X-MC-Unique: v7G_8dPdPqKci2i7TFObCQ-1 X-Mimecast-MFC-AGG-ID: v7G_8dPdPqKci2i7TFObCQ_1745860339 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39131f2bbe5so1310152f8f.3 for ; Mon, 28 Apr 2025 10:12:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745860338; x=1746465138; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=12QvVqLXlGs5CmweSckIByUDZ+ahkk4NQsvXAkhd9vo=; b=i0nSFl8FE6DdK1Tk73UK1KjLZHdSt61Pv8eXsdJmKg/t/vp1WaGaowUhXYHBpJb0Xv bwv8IByVTYrKIH4/BundxGDz5RTyQR1Q5nYI1GDn433mKFattZ58ZzxINR0Z1pB8svjB ZDBYDgLljxY+5tFGGRev9Lv3Q7vVihHiSJnUQDIkA80TKWOZfU+8l4zIXH6zmgeHkx9A tm0G1B1w7eGQg/4WPsSi1+vdgHAXUISp2f9vdauz8PlLwQO6vcp8p07fIzIAcpR4ov8U aa1R3dXQPmD+sxafq6rTqvDX+0AMGy+trYDCsLlsE4Lyb/mCvBwFm/MeYoYULq6y3QMV 4HFw== X-Gm-Message-State: AOJu0YyqC7L+vMpwGLognU5EbWjVfxf0FeuUrvc0qEF9InR/uqFytkL7 bsh6RiyPSaI/PxyJ6Y8bKyVHgYsKAzEcMzA5TkOy7Mtgf/ge0YG1DueRiGZTdNK8JP1pKOlLlha nUgLnImEBWB+FO/pyc6uTe+bMPCFeFvQ4+YOwebaZKqjLJWk78IXGsUw8uThpHC/4PRk= X-Gm-Gg: ASbGnctAaMBfjTNT5xVEPtVEy7Uk5vSBIkQGR0DgXd4eiZ1V9j4fwSSUCntiRKJPb5f HsHGI1wHiICfslqpZLxIiccQyR6EzOvSsjmh7n8P0AFk/izTmkNHTr3N7k4ckTIQXmoAw3M8XzH LC0ZJBYJ1fq/P8Lm+Gck4B2PGxLJRDYnw5G2MEeHRinia7+g49uk6+gxF2MH1r8g8ys7kBTR9LN yioyjG7yqwZ3bz8umCuoaChUZ41iSZ1d2FIKEB8gDaSkhem+dg5ObWOSI/Kodb/ObWl6vKiP3E4 jHU0zYjmmMOpzBe+dTT2898IYLpWeyBTaG7P X-Received: by 2002:a5d:5592:0:b0:391:4674:b136 with SMTP id ffacd0b85a97d-3a0891abe7emr359053f8f.29.1745860338391; Mon, 28 Apr 2025 10:12:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIy0HultltvRy22XFpVyvyallHlkKf3p7L9j9pvQBm8aPHDSVy0IzWDC2J38a0FvTmNuLRrw== X-Received: by 2002:a5d:5592:0:b0:391:4674:b136 with SMTP id ffacd0b85a97d-3a0891abe7emr359045f8f.29.1745860338042; Mon, 28 Apr 2025 10:12:18 -0700 (PDT) Received: from localhost (30.226.159.143.dyn.plus.net. [143.159.226.30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073cbefc0sm11995357f8f.51.2025.04.28.10.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 10:12:17 -0700 (PDT) From: Andrew Burgess To: Charlie Jenkins , snatu@whileone.in Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PATCH v3] RISC-V: support for vector register accesses via ptrace() in RISC-V Linux native In-Reply-To: References: <20250424121915.1203050-2-snatu@whileone.in> Date: Mon, 28 Apr 2025 18:12:16 +0100 Message-ID: <87msc06wi7.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KLSW6yeeEl2rEc8F91KCvmaQSm8IDLolTe4YMfb82yA_1745860339 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Charlie Jenkins writes: > On Thu, Apr 24, 2025 at 12:19:14PM +0000, snatu@whileone.in wrote: >> From: Sameer Natu >> >> A v3 re-spin of the original patch. >> Tested with latest kernel 6.14.2 on RISCV QEMU. >> Removed Magic Numbers from v2 patch and worked on review comments of v2 patch. > > Thanks for working on this! > > Can you add a co-developed-by tag for the original author? > > You also don't need to have [PATCH] twice in the header! > > There are a handful of erroneous spaces at the end of lines. > > I tested this patch and I noticed that the vector instructions are not > being decoded. > > Breakpoint 1, vector () at main.S:4 > 4 vsetvli t0, a0, e32, m4, ta, ma > 1: x/i $pc > => 0x55555555566c : .insn 4, 0x0d2572d Does an `objdump` built from the same tree decode these instructions? Wondering if this is a problem with the objdump disassembler library, or a problem with the way GDB uses that library. Thanks, Andrew