From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow conversion of 128-bit integers to Python
Date: Fri, 05 Sep 2025 11:26:48 -0600 [thread overview]
Message-ID: <87ms78izdz.fsf@tromey.com> (raw)
In-Reply-To: <84ce5145-0c06-487b-81f5-c6c232f5949e@simark.ca> (Simon Marchi's message of "Fri, 5 Sep 2025 11:26:04 -0400")
Simon> If we are forced to use kwargs, I think we might as well just use kwargs
Simon> for all the args.
I don't see that this provides a benefit, but I went ahead and did it
anyway. Note that PyObject_Call requires a tuple argument, so we end up
creating an empty one.
Simon> Can you add some comments above the Python API calls, just to explain at
Simon> a high level what this is doing, so that someone who doesn't know the
Simon> Python API by heart can follow what is happening?
I did this. I'll check it in shortly.
Tom
next prev parent reply other threads:[~2025-09-05 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:29 Tom Tromey
2025-09-05 15:26 ` Simon Marchi
2025-09-05 17:26 ` Tom Tromey [this message]
2025-09-05 17:51 ` Simon Marchi
2025-09-05 17:58 ` Paul Koning
2025-09-05 19:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms78izdz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox