From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GYiZLxlDcmnO8Q8AWB0awg (envelope-from ) for ; Thu, 22 Jan 2026 10:32:41 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FgPKZNpX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF2E01E08D; Thu, 22 Jan 2026 10:32:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCAE01E08D for ; Thu, 22 Jan 2026 10:32:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8F5304BA23E7 for ; Thu, 22 Jan 2026 15:32:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F5304BA23E7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FgPKZNpX Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6584C4BA23C1 for ; Thu, 22 Jan 2026 15:31:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6584C4BA23C1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6584C4BA23C1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769095916; cv=none; b=xo7kFm99OL5MmyQvb/RJ7+w/faeGVktQ/hPw+SMgxenfaw0mZArDkH/6oubTdQaIWaxK47tx5KnuP59QWxkyHiCDlC0kDkrSAb2GiXvF812rGcpfZSPwuhoGiqzYpCPwYqyRKCaOoAYvfG4LCN5W4QWxyFm9xfqhhupdj3e7R2M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769095916; c=relaxed/simple; bh=VmdUDjl5v1LEzbImwflC2i27djSHE9zy20zHAkURRBE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dUuEFQ8Ecr0M2Z0+nlK0eEnQ62sxH5y1DKS226OXFMS8ixrLy2WXxF1mnXy6vmz0DubfZbF3fCwfbgE+jcLnIJ5baa0mrXM5jlNxdOMiUBXneDbOux/UOM2WfMt5d4q1v7rk9XvF95ulq+sa96dNmuIAZVQOWU4lFMYwz4TINIw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6584C4BA23C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769095915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8LfVHzdVZc0xwyxU6ZsUxPhKPF6YxhJFGA3DuYz0it4=; b=FgPKZNpXJtd0vdI9EWxoHmAfGs1KPmYxWBQIdJVimQNqq3Qhn7v+KmgAB73/6ZaNP4EXzw a7CLX56ip3oDkCtqDhZOBIhL5FECr/WNtw4hgownAwoRJHOa5n7EHzA+fkEXvpWTGFmymK /S3qotvKarzvOiQhsSpnfPQAGStgvzs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-BnlnNeZFOzavXjVfleYIvw-1; Thu, 22 Jan 2026 10:31:54 -0500 X-MC-Unique: BnlnNeZFOzavXjVfleYIvw-1 X-Mimecast-MFC-AGG-ID: BnlnNeZFOzavXjVfleYIvw_1769095913 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-435af2d3144so263983f8f.3 for ; Thu, 22 Jan 2026 07:31:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769095912; x=1769700712; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8LfVHzdVZc0xwyxU6ZsUxPhKPF6YxhJFGA3DuYz0it4=; b=C1M9XcT7BuTBqPLvIDvw5+MHV+3fypfG6iBHFamzrSu0oCHFuGEXiPtXN4IxG2uaC6 LiSLyzsWBZTDMJ9DCI5WJqvhEC6ymO0FMkjRIMZNuabv9FWEZxyYzwEW3yTccxrDK88F LRdLe5UqKtlWiNc9RalABfDQ9ZThacMHL2L4q3gidq5cm1xxFiByUt2t4kUUUSXtnBzL UVBI3qfhhIg9osQ2XvJBUNANvAcRtNS7grlIn7zhlPE5QF2hxM+PJ2piJqKVtC0Vzk9M WEE+MgwgGrS4VPkqJtfjnO9UyhpyXp9xjH3oiy9VvprxLJgO0jHiAwN+Ex86ji4BYqZI BUhA== X-Forwarded-Encrypted: i=1; AJvYcCXj+3u6r/symGn+8rr+u65zV97VJbErb2w5MSaORfnn3ONkhG1P+UPtSyVfseD1QJObOO1q/K0dSEkt7A==@sourceware.org X-Gm-Message-State: AOJu0Yw0r6O8iFPT9kd7xSUkhvSde1NGG4bf8ooZEkfc2e8jYBBTiePa ZhImTUaj4zcHRmC3hJQ743bzqvRT9BPhs8pQUlaNmSVTQOE1c5XltkhDZ93+V+acLI9YOGbJZva tRAIDk4mvEKXprj4rBDEVKAz+YtgECsWRvHNcBvk6z4w1A4jCRfemn6gq7VP+IwW6S+AqpXI= X-Gm-Gg: AZuq6aJyu1E9SUza5Y+JZYibw4gUCXgR+aIHbuUStn9C4sS/Ru2xhj3jnSbb9oodi0i s9zY7GjnzhFr0mz+5Leqmt1tF92CMWcRKgd6/EjdanioZc4ZtD8ECEfJur0GXx0XrRwu3ExVgF5 /P0yIx4sF/i9D3BqT2gjmGPvKsmxATd96ETt5RqlYee2e5pFEKvx6Y2iYTA2l+vlYWQ5+HnYQu7 BNKVqjEIiIY4/Eb/AcdcInEIOFvEkoDW441vpwhbT4BSXAa1vmw2iJDw+iEWrorY2EjlMzJXxwA 8SsSXBAoQV6Imp8erFNLlRfhg19dx+Mn4aSZ+w3bKtGbBnSUPhlggsPTwqoj5nLWqIvfNIVd3ph dwN7J X-Received: by 2002:a05:6000:250a:b0:435:975a:131c with SMTP id ffacd0b85a97d-435975a1466mr11989102f8f.36.1769095912511; Thu, 22 Jan 2026 07:31:52 -0800 (PST) X-Received: by 2002:a05:6000:250a:b0:435:975a:131c with SMTP id ffacd0b85a97d-435975a1466mr11989053f8f.36.1769095912013; Thu, 22 Jan 2026 07:31:52 -0800 (PST) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356997e6cdsm47292503f8f.31.2026.01.22.07.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 07:31:51 -0800 (PST) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: fix failure in gdb.server/fetch-exec-and-args.exp In-Reply-To: References: <3d52893e-d2a8-48e9-aab0-b0c85d736de4@simark.ca> <19b4a897d945398861334de10c7c2c3367ecec3a.1768420854.git.aburgess@redhat.com> Date: Thu, 22 Jan 2026 15:31:50 +0000 Message-ID: <87ms25hdeh.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -rufZ-515g01tU7QCqYn3WhiJuzustZFOzeisLgs4lw_1769095913 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 1/14/26 3:01 PM, Andrew Burgess wrote: >> Bug PR gdb/33792 reported a gdb.server/fetch-exec-and-args.exp FAIL >> when using the native-gdbserver board: >> >> FAIL: gdb.server/fetch-exec-and-args.exp: packet=on: set_remote_exec=false: test_server_with_no_exec: show remote exec-file >> >> The actual test output looks like this: >> >> (gdb) show remote exec-file >> The remote exec-file is unset, using automatic value "/tmp/build/gdb/testsuite/outputs/gdb.server/fetch-exec-and-args/fetch-exec-and-args". >> (gdb) FAIL: gdb.server/fetch-exec-and-args.exp: packet=on: set_remote_exec=false: test_server_with_no_exec: show remote exec-file >> >> This test actually fails with native-gdbsever and >> native-extended-gdbserver boards. The problem is that these boards >> clear the sysroot. >> >> This exact test has the following conditions: >> >> + The qExecAndArgs is in use (see 'packet=on'). >> >> + We're not explicitly doing 'set remote exec-file ...' (see >> 'set_remote_exec=false'). >> >> + The test starts gdbserver without an executable (see >> 'test_server_with_no_exec'). >> >> + And because of the native-gdbsever board, the sysroot is "". >> >> What this means is that GDB knows that gdbserver doesn't have an >> executable thanks to qExecAndArgs, the user hasn't set an executable >> for GDB to use when starting a new inferior, but GDB does know that >> GDB and gdbserver can see the same filesystem due to the sysroot >> setting. GDB will then automatically use the current executable as >> the remote executable name. The test script doesn't expect this case, >> and so the test fails. >> >> Fix this by adjusting the script to expect the 'using automatic value >> ...' text when appropriate. >> >> I also extended the test_server_with_no_exec proc to take a new flag >> 'clear_sysroot', we now run the test with the sysroot set to 'target:' >> and with the sysroot set to "", even when using the 'unix' board. >> >> Additionally, I ran the test through check-all-boards and found one >> additional failure, when using --host_board=local-remote-host-native >> and --target_board=local-remote-host-native. In this case GDB copies >> the executable to the remote host, which changes its filename. When >> the filename appears in the 'using automatic value ...' text, I was >> expecting the filename assuming a local host. >> >> I could fix this, but it doesn't seem worth the extra complexity for >> this one test, so I've just set the test to be skipped for that one >> configuration. >> >> Now, when using check-all-boards, I'm seeing no failures. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33792 > > It appears to fix the failure on my side. Thanks for the quick fix and > for improving the test. > > Approved-By: Simon Marchi I forgot about this one. Now pushed. Thanks, Andrew