From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /dySKE5sl2nfzgEAWB0awg (envelope-from ) for ; Thu, 19 Feb 2026 15:02:22 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qby05B0h; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 87BF21E08D; Thu, 19 Feb 2026 15:02:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE48A1E08D for ; Thu, 19 Feb 2026 15:02:21 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4F73F4B9DB6D for ; Thu, 19 Feb 2026 20:02:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F73F4B9DB6D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qby05B0h Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id CBB854BA2E0E for ; Thu, 19 Feb 2026 20:01:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBB854BA2E0E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBB854BA2E0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771531313; cv=none; b=BX9eWdmYoP66jXCBHD+7Bz2m2kN27iokPu0WYBT0bjaVvOoms6RKMV07oCRcmf+EjjCcMC0J1Rqi4uryPwfBN4yf4O7kSqP4QbNfpfX+mPwIlUVjLfMt0PdkvzZHJVoE4trlpSm3ybQiUZ3+KMaTdqTm8gJM1UTiET/NlIQE6Hc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771531313; c=relaxed/simple; bh=23sh7zLJg+sT0rA4cgK7FBMPJdTdie0qatZzIWqFu84=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LVAkKcO3sI5AbCRTScGN3xpCU3giF3xNOO1AnDjeUBpZFlpYV+w+jb3veyxhrx4PjMfr9yrhFGM6AlVhl6Dr5g1IXOnN+5iykZdE6wWhl58OOuYDPNBENA9qoSsWgSd9zEFF6A0nnV5HTR3x4mpMB99PiEplgmqW4dc/J9oyzL8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBB854BA2E0E Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id t8L9vuhOKipkCtADfv0mEz; Thu, 19 Feb 2026 20:01:51 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id tADCvbIp1HSQMtADCvWDTi; Thu, 19 Feb 2026 20:01:22 +0000 X-Authority-Analysis: v=2.4 cv=GIQIEvNK c=1 sm=1 tr=0 ts=69976c2f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=rMInTUv2ajWg6o5xJhYA:9 a=4IKI_MBedZsHOhguCAbN:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YejO6G83UyjnsQq3Fy24GI1p4GYab2Z1nPD7OJ3loeI=; b=qby05B0h8qkzA9bQO/CIJJSIbJ QYOUzyByE1Gy9Li38w9bNwuxkI/V3UxxCzvDM24v62jkFlBokSsH/Bc8gBlou8S2hz1/vc9vqfJPp LPPoRu8eyx02aBpGOHWtDk4Sq; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:46624 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vtADB-00000003rTu-3XFw; Thu, 19 Feb 2026 13:01:21 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab In-Reply-To: <20260219185638.360694-2-jan.vrany@labware.com> (Jan Vrany's message of "Thu, 19 Feb 2026 18:56:32 +0000") References: <20260219185638.360694-1-jan.vrany@labware.com> <20260219185638.360694-2-jan.vrany@labware.com> X-Attribution: Tom Date: Thu, 19 Feb 2026 13:01:20 -0700 Message-ID: <87ms144i5r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vtADB-00000003rTu-3XFw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net (bapiya) [97.122.122.234]:46624 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBt70OkKFE2xZH3KUbTDFiv+wI2wzxG2xf3wRd3Ra1TKBjj2MTxFXyP2HpAB6R2qbLiw5OwuLTjoGz4WK9vahr0WfQAxFaMSHPt06OS3IDW4p0Koj+8a 09tqX82CExtHAYMHESBaXKDSLH9wLTl3TtM/lq5JRn2MiDQHA9MsMFNfPWTXSgmE3jkM9zR5l1eA8X8fpNtJiBsOALxhfV4zncI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> +struct compunit_symtab * Jan> +readnow_functions::find_pc_sect_compunit_symtab Jan> + (struct objfile *objfile, Jan> + bound_minimal_symbol msymbol, Jan> + CORE_ADDR pc, Jan> + struct obj_section *section, Jan> + int warn_if_readin) Jan> +{ Jan> + dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile); Jan> + dwarf2_per_bfd *per_bfd = per_objfile->per_bfd; Jan> + Jan> + /* This invariant is documented in read.h */ Jan> + gdb_assert (per_bfd->index_table == nullptr); Jan> + Jan> + /* Since we have no index, we simply walk all units until matching CU is Jan> + found (of there are no more CUs). */ Jan> + for (int i = 0; i < per_bfd->all_units.size (); i++) Jan> + { Jan> + dwarf2_per_cu *data = per_bfd->all_units[i].get (); Jan> + compunit_symtab *result = find_pc_sect_compunit_symtab_includes ( Jan> + dw2_instantiate_symtab (data, per_objfile, false), pc); There shouldn't be any need to instantiate a symtab here, since for readnow they are all already expanded. Tom