From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MDAFKjNr4mnmeh8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 13:17:39 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hpybRmlf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 881341E0A2; Fri, 17 Apr 2026 13:17:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D9E41E0A2 for ; Fri, 17 Apr 2026 13:17:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 125ED4CCCA2D for ; Fri, 17 Apr 2026 17:17:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 125ED4CCCA2D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hpybRmlf Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id A53244AA3946 for ; Fri, 17 Apr 2026 17:17:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A53244AA3946 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A53244AA3946 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776446233; cv=none; b=hsHY4S74eJzx3fSk0sAqgmqAZ734gey5cIo5SfAAVHEAjeNihozaf2A45y15mGFVps11l/5zlqGqGtCVVdKyTKxXrPmmScu+tFWyOes9dgSLNc8XaDj99w6UgQsSmnUn2PzZAaE7npsfwKPwSj5Z83NIafHPEYa3Po4ymhJHoT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776446233; c=relaxed/simple; bh=ZZS+EEUTeHASTzYDhh8/J9TrS49r6MRfEM0PYBpy2PI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DnStXmGg3ZZnKuob3I5Fz5xRFe1sV9wujnAfdCLGIVfkV9iLiMawEnHlAhmgxSwY9yzQgu1MkKUqjtEkrIUW1ndDwW/5FUt1HrLN9Ppifbrl+hHqa8BrGdGjmRiAUcCmuyDAjOCddoG/4Gj0A2xRzYsOpAczy09d0wyo8vvCfRk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A53244AA3946 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id Die8w0TLR4RkpDmobwrPB5; Fri, 17 Apr 2026 17:17:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id DmoYwq6rEwWe6DmoYwWoBj; Fri, 17 Apr 2026 17:17:10 +0000 X-Authority-Analysis: v=2.4 cv=RfSQC0tv c=1 sm=1 tr=0 ts=69e26b18 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=PO7sxYk4Df8pYk-ImtoA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rz9XadWr33mzjc/hUuz5qFa6+p3ScMRpIM8B5BlYSu0=; b=hpybRmlfeNMrJtmZ6Jx561cxwo tAOca4h+5JGDtr/v5825+divPjEoTPZayrI/gpsI7HTG1vwlmdjxZWY9V49kfKwuabkaLVXzUGquX wxEogD7Br9FONhUwLPK/rfelL; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:55302 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wDmoX-00000000XKE-3MfZ; Fri, 17 Apr 2026 11:17:09 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 02/11] gdb: rename search_symtabs_expansion_listener -> compunit_symtab_iteration_callback In-Reply-To: <20260416202408.422441-3-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 16 Apr 2026 16:16:12 -0400") References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 17 Apr 2026 11:17:08 -0600 Message-ID: <87mrz1se0b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wDmoX-00000000XKE-3MfZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:55302 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEJJKU736/P9vTNZM/7H1t+HS609aWHYimtanwMupGr/ks2NJIb6GrhMI2k4sakobSlr57sw2YR9Q4ewyk2kaGTEdG16pXL5GIHOOVa+smssFT+GveYg evQ0uF0vnziw9aaUjfGm0MfFBgdM+hXhF87CImE7PW16NbXrf5SrCvmZ/GNtrk2Q4aL4kO99YrRak4XcIhSHhz+y9+nFfeVN8DE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> From: Simon Marchi Simon> I think that the name search_symtabs_expansion_listener function type Simon> no longer makes sense for the following reasons: Simon> - Since we have both `symtab` and `compunit_symtab` structs, I like Simon> when we are specific about which one we're talking about. In this Simon> case, the callback takes a `compunit_symtab`. Simon> - Following series "Search symbols via quick API" [1] last year (I Simon> believe commit f88f9f42db8 ("Have expand_symtabs_matching work for Simon> already-expanded CUs")), the callback gets called for all matching Simon> compunit_symtabs, not just those that get expanded. Simon> I therefore propose to rename it to compunit_symtab_iteration_callback. Simon> I chose "callback" over "listener", because I think that listener Simon> implies that there is some event happening, that we listen for. That Simon> made sense before where we would listen for the "expansion" event. But Simon> now since it just gets called back for all matching CUs, I think that Simon> "callback" makes more sense. This seems fine to me, thanks. Approved-By: Tom Tromey Tom