From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AR1XCaItg2rMMy0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:49:54 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U/4j27kB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 214E41E033; Mon, 17 Aug 2026 11:49:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A3A481E033 for ; Mon, 17 Aug 2026 11:49:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB75D4B9DB53 for ; Mon, 17 Aug 2026 15:49:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB75D4B9DB53 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U/4j27kB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 805ED4BA903F for ; Mon, 17 Aug 2026 15:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 805ED4BA903F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 805ED4BA903F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786981763; cv=none; b=e71xL2veAROLVCcTX2uYTIzcDTdohRUd8wYsg5KYtX0VwRKu0hdIfDBgexAfpABS73J41otzwQWiM5wIW1bs95icxdR8EJ/wQIhQKTJ+aIaHqU5AGg23Us0SypMg9uf+4Z1nxIczpP7CTOIuA2dvAI/7b2NvP+otVBhvyJ3MWMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786981763; c=relaxed/simple; bh=YdOc4RVoQqQuLafXJLPYHsHId8rWECzvwqaflrLvqIY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QlJ2PwzlfeFdSMmBygRQ40Kz5l+c4pK0ABqpHv+bsDGgBCRAXiQ6CY5Y1sjSV9SIi+p4Wp7UiZEw5PFqjc1GL/IL7LOFylzRGQy3fVKt4nCKYn2lsv3Hua6czLbmFtp/1qH6StHF0k7DjfYTZ1gvHVigf5io+ynBTH+/Mnkn2wA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U/4j27kB DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 805ED4BA903F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786981763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FCoJh5YIZRV4kZr2Z9R+cMmtzUHdBAk3Y/68r7/3eGo=; b=U/4j27kBOWMtQxBMgzG5NZOCEpkJfC5nT3/ZxD6JhU/V+NjtC8niX5YDc15nldsFLU6jCE gIyZp3RbnyYkR7iIfhm6vXA/s/wYUSy9mYZ0ELZlYrWZQk6cBjjsXUIwRA35a8UiiZyW+5 VAiOecc2NG5HEH8yH14HWoPH6BMEpkk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-k9MgZ6UIPHu0hcBDKA1srw-1; Mon, 17 Aug 2026 11:49:21 -0400 X-MC-Unique: k9MgZ6UIPHu0hcBDKA1srw-1 X-Mimecast-MFC-AGG-ID: k9MgZ6UIPHu0hcBDKA1srw_1786981760 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47fe23b5acdso3072447f8f.0 for ; Mon, 17 Aug 2026 08:49:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786981760; x=1787586560; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FCoJh5YIZRV4kZr2Z9R+cMmtzUHdBAk3Y/68r7/3eGo=; b=lDP9vKlUQNehUg55rTQ2gAkLip3WdVSWmz+mHNcf64ltCgipK0ZFnJcAaqEQdSdCwH VbEbc/kD6UqzsA61VCdKYc/05BE2Fl00Odtn+rFBPukXWzaZx9MMeZR0Zc+WK4W+fT36 JN3yCrrIhuiJisWVh+YwGqKyb1/OEL8fJSTdLv+MkjvkvXwXMlkCIx+trT4FBueY9hzk pVpCzkX7FybfMP1/Nl8QV8reTeX4UFiXNXm3u4HCo4h34hFBKukPz4pKaStfJDsIrsY+ oVanmXKnwhtheLj8Iqh25uIgkQAuqenaiFrIi3itasL98C6hR6Yj3lhSnXtRhCPYojg+ lqiA== X-Forwarded-Encrypted: i=1; AHgh+RoGRK5K4IFa2A/azQWSpeGfl3YIdPRaCmlXh6900H6YkIUYAsHG0jo2AbgwxPeC+R7ZwVGO1SVzzpm5QA==@sourceware.org X-Gm-Message-State: AOJu0Yw3Ve5DCsWYIKIdKUBjQsjgoji4JPYyGOvlq/9ceyfJksAbO0Zw Q/XJzBhEmwrx8HUddQOmKuUEOX2vt/3ISWSiVKmT83HSpwAfoEZkr++nFudjOjfXu+YLKjqL2Qw aDvyYsFlzJRG9Wi9xHqkBliyfCGh3DO/GzWkvrgGLIXaTCdm4WuAwHDLjAP55uBk= X-Gm-Gg: AR+sD11l9vhOn+IM8WCgNgj7n9DzeeCNXEtw0NxVd9z4opGJ4v4bOH0kFB6ML7sPv+h KtUiC8LxAWuRZsMn6oJXP9DbDIWUa9tpHXGW6ZB9E1EvxddI3dSaGGM2yJuxSa6OHqhr2gapsBm P4TMtxerdRvXrkt7kotv2WoTi88IToE1b4V0+c3zybud/BBugM8dlNkIrDnYHeNykZTIRRbXrDV UX0ivT062zBlW/0F9xaAVhGXVg37+76k4LzACXbwL560lUpUyRamox6ehrL6LwoOc+Tk5xV6ZuF 8/P5/af9WcY6Cb6KyR86g5wsUFrXru+J8St1PhT32D4ILS7QnvFySimE7wCO4jaW0XhOOpKr0PF g5Hc5UYB/dzgb/qtP7Fs= X-Received: by 2002:a05:6000:46cc:b0:47f:f3f9:ae37 with SMTP id ffacd0b85a97d-48160705704mr28451237f8f.7.1786981759798; Mon, 17 Aug 2026 08:49:19 -0700 (PDT) X-Received: by 2002:a05:6000:46cc:b0:47f:f3f9:ae37 with SMTP id ffacd0b85a97d-48160705704mr28451175f8f.7.1786981759321; Mon, 17 Aug 2026 08:49:19 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b81748sm5353422f8f.37.2026.08.17.08.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 08:49:18 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 02/13] gdbsupport: remove uses of sprintf In-Reply-To: <20260817151646.152571-3-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-3-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 16:49:18 +0100 Message-ID: <87mruk3fy9.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vw92BEq6KXUgYanTwbWICCtj_2HhqITCNN7FwKJE8wU_1786981760 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, I get some errors about the uses of sprintf: > > CXX xml-utils.o > /Users/smarchi/src/binutils-gdb/gdbsupport/xml-utils.cc:91:8: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] > 91 | sprintf (str, "%d", va_arg (ap, int)); > | ^ > > We know they are safe, because the 32 byte destination buffer is large > enough for all conversions. But I also don't think it's a big deal to > switch to xsnprintf to avoid these errors, and to catch any future > error. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: If3531e1916e103dfccd0ec033639b14a2b6df3cf > --- > gdbsupport/xml-utils.cc | 35 +++++++++++++++++++---------------- > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/gdbsupport/xml-utils.cc b/gdbsupport/xml-utils.cc > index 13dc27499120..cec7281c9297 100644 > --- a/gdbsupport/xml-utils.cc > +++ b/gdbsupport/xml-utils.cc > @@ -88,52 +88,55 @@ string_xml_appendf (std::string &buffer, const char *format, ...) > str = va_arg (ap, char *); > break; > case 'd': > - sprintf (str, "%d", va_arg (ap, int)); > + xsnprintf (buf, sizeof (buf), "%d", va_arg (ap, int)); > break; > case 'u': > - sprintf (str, "%u", va_arg (ap, unsigned int)); > + xsnprintf (buf, sizeof (buf), "%u", va_arg (ap, unsigned int)); > break; > case 'x': > - sprintf (str, "%x", va_arg (ap, unsigned int)); > + xsnprintf (buf, sizeof (buf), "%x", va_arg (ap, unsigned int)); > break; > case 'o': > - sprintf (str, "%o", va_arg (ap, unsigned int)); > + xsnprintf (buf, sizeof (buf), "%o", va_arg (ap, unsigned int)); > break; > case 'l': > f++; > switch (*f) > { > case 'd': > - sprintf (str, "%ld", va_arg (ap, long)); > + xsnprintf (buf, sizeof (buf), "%ld", va_arg (ap, long)); > break; > case 'u': > - sprintf (str, "%lu", va_arg (ap, unsigned long)); > + xsnprintf (buf, sizeof (buf), "%lu", > + va_arg (ap, unsigned long)); > break; > case 'x': > - sprintf (str, "%lx", va_arg (ap, unsigned long)); > + xsnprintf (buf, sizeof (buf), "%lx", > + va_arg (ap, unsigned long)); > break; > case 'o': > - sprintf (str, "%lo", va_arg (ap, unsigned long)); > + xsnprintf (buf, sizeof (buf), "%lo", > + va_arg (ap, unsigned long)); > break; > case 'l': > f++; > switch (*f) > { > case 'd': > - sprintf (str, "%" PRId64, > - (int64_t) va_arg (ap, long long)); > + xsnprintf (buf, sizeof (buf), "%" PRId64, > + (int64_t) va_arg (ap, long long)); > break; > case 'u': > - sprintf (str, "%" PRIu64, > - (uint64_t) va_arg (ap, unsigned long long)); > + xsnprintf (buf, sizeof (buf), "%" PRIu64, > + (uint64_t) va_arg (ap, unsigned long long)); > break; > case 'x': > - sprintf (str, "%" PRIx64, > - (uint64_t) va_arg (ap, unsigned long long)); > + xsnprintf (buf, sizeof (buf), "%" PRIx64, > + (uint64_t) va_arg (ap, unsigned long long)); > break; > case 'o': > - sprintf (str, "%" PRIo64, > - (uint64_t) va_arg (ap, unsigned long long)); > + xsnprintf (buf, sizeof (buf), "%" PRIo64, > + (uint64_t) va_arg (ap, unsigned long long)); > break; > default: > str = 0; > -- > 2.55.0