From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SsQDE2S04Gp5ZS8AWB0awg (envelope-from ) for ; Tue, 27 Oct 2026 10:25:40 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gzkxO5f7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3F2E6378002; Tue, 27 Oct 2026 10:25:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 644C1378002 for ; Tue, 27 Oct 2026 10:25:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3507B4BA7994 for ; Tue, 27 Oct 2026 14:25:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3507B4BA7994 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gzkxO5f7 Received: from omta033.useast.a.cloudfilter.net (omta033.useast.a.cloudfilter.net [44.202.169.32]) by sourceware.org (Postfix) with ESMTPS id 67F7A4BA23E4 for ; Tue, 27 Oct 2026 14:25:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67F7A4BA23E4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67F7A4BA23E4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793111111; cv=none; b=KNjcJqgUhx5+K7G2r7JUcco4R/EQL0tATwrLzXSiMTibCbcQl+s9hoPSJpYwBL3k4R6iVcmfEATXIptsZzJUWgrXe2tHRC9LRWMx5Wb/HsOOxoT4I5Gc/nNBs7y23MnTJ5nXSFlUYrztUw/i46h/0JVVztkA7JNEFuSYXuvTceM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793111111; c=relaxed/simple; bh=hVCnfRF6q65YnUn09hr7rqTRehP5lGDIs4/4H7KqF/I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oOK/se1bpCqaFnvCUhH55LPurBGXRXTGi1YNyniciEr0Cy389ENZlfxSxMI+h489KObvLyNM+eOqKD6p+Di+Uf4NEWVlkM0gdBKLNDpo7kWa3RkWeMx/J06A5NUbHxiS326/F8Hq/y6bgExJbgS34DUSEQoVjIz3gYP3JPi/fII= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gzkxO5f7 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67F7A4BA23E4 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id LetbxvNnJPG7QLi6xx4erA; Tue, 27 Oct 2026 14:25:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Li6wxLKfwp4IlLi6wxMZCP; Tue, 27 Oct 2026 14:25:10 +0000 X-Authority-Analysis: v=2.4 cv=X59SKHTe c=1 sm=1 tr=0 ts=6ae0b446 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=_l9nSUiyvkVV7HtMpQwA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b5GXTQakMNuk+63JwQnEwziIxAQouUUmp71xyjY1Ekc=; b=gzkxO5f7pOGpQXY6hHaTrSYK/H ozv10WkEzouLPxS3r4ITlIfrYCGT+dXP9WdGly7dVPPuiJcqEfF0sAaM0xh13RkVSw+SnSDMRtTHT wFiv7p5dl0VvQQ7APHn011bZV; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:57622 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xLi6v-00000001dQ7-2rS8; Tue, 27 Oct 2026 08:25:09 -0600 From: Tom Tromey To: Eduard-Petru Jipa Cc: gdb-patches@sourceware.org, stephan.rohr@intel.com Subject: Re: [PATCH v3] gdb: don't abort shared library reload when one library fails to open In-Reply-To: <20261008130642.54868-1-ejipa@undo.io> (Eduard-Petru Jipa's message of "Thu, 8 Oct 2026 14:06:42 +0100") References: <20261008130642.54868-1-ejipa@undo.io> X-Attribution: Tom Date: Tue, 27 Oct 2026 08:25:08 -0600 Message-ID: <87mrrzp6ez.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xLi6v-00000001dQ7-2rS8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:57622 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMrogS66k46J65bwyu3c5u8WilQaImZMkzBB9Sio4SZxkXBerm5AzDRMKRj+JJzJ/jnGsUJxRok1gY0fi3ey1xl8lUtiBebi/+MIWJtV2kjn6WNgLM6X LPrKm/8s5z0+qD10rZJFrbqrGakgS6G/GP5mYXvXaSZzllY+wrhdVzlm1P2JjVARqZKghlbTTIoTYnm//ysVzNB/gQDhk4AcCiA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Eduard-Petru Jipa writes: > From: Eduard Jipa > When the set of shared libraries is reloaded, for example after > 'set sysroot' or 'set solib-search-path', reload_shared_libraries_1 > calls solib_ops::bfd_open for each library in turn. This can throw an > error, for example if the file found is not in executable format, or > its architecture is not compatible with the target. > Nothing in the loop catches that error, so a single bad library stops > the whole reload. Any libraries after it in the list are not reloaded, > and the error propagates out of the command that triggered the reload. > Catch the error, print it, and carry on with the rest of the > libraries. This matches what is already done for errors from > solib_map_sections later in the same loop. The library that failed > to open is handled as if it had not been found. > Add a test that builds a sysroot in which the first of two libraries > is not a valid object file, and checks that, after 'set sysroot', the > first library is no longer loaded and the second library is reloaded > from the new sysroot. This looks good to me. Thank you for doing this. Approved-By: Tom Tromey Tom