Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFC: fix crash when inferior exits during "continue"
Date: Thu, 16 Feb 2012 14:42:00 -0000	[thread overview]
Message-ID: <87lio2kfjo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F3CEC0E.4070603@redhat.com> (Pedro Alves's message of "Thu, 16	Feb 2012 11:44:14 +0000")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Tom> This makes sense to me if the user entered a background command.
Tom> But why not switch if the last command was a foreground command?

Pedro> Yes, agreed.  The lame reason is that the original non-stop work didn't
Pedro> care that much about the CLI (and there's no foreground in MI), and I
Pedro> have an old TODO item for that, that I never got around to.  :-P

I'll file a bug.

>> +#include <stdio.h>

Pedro> Doesn't look necessary.

Oops, I missed this comment before check-in.
I'll fix it now.

>> static void
>> @@ -1095,6 +1096,8 @@ do_restore_current_thread_cleanup (void *arg)
>> set_current_inferior (find_inferior_id (old->inf_id));
>> }
>> 
>> +  current_inferior ()->removable = old->was_removable;

Pedro> This is unnecessary.  restore_current_thread_cleanup_dtor
Pedro> is called when either you run or discard the cleanup.

I did manage to make this change before committing.

Tom


  reply	other threads:[~2012-02-16 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 19:14 Tom Tromey
2012-02-10 14:41 ` Jan Kratochvil
2012-02-10 20:05   ` Tom Tromey
2012-02-14 13:44     ` Gary Benson
2012-02-14 14:19       ` Pedro Alves
2012-02-15 22:24         ` Tom Tromey
2012-02-16 12:45           ` Pedro Alves
2012-02-16 14:42             ` Tom Tromey [this message]
2012-02-16 15:24               ` Tom Tromey
2012-02-20  2:41           ` [patch] testsuite: Fix inferior-died.exp racy FAILs [Re: RFC: fix crash when inferior exits during "continue"] Jan Kratochvil
2012-02-20 21:05             ` [commit] " Jan Kratochvil
2012-02-20 21:24             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lio2kfjo.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox