From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7652 invoked by alias); 9 May 2012 20:57:32 -0000 Received: (qmail 7641 invoked by uid 22791); 9 May 2012 20:57:31 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 May 2012 20:57:12 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q49Kuo9L014157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 May 2012 16:56:50 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q49Kumo3001072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 9 May 2012 16:56:49 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] choose symbol from given block's objfile first. References: <1336430581-11262-1-git-send-email-brobecker@adacore.com> <874nrqvbeh.fsf@fleche.redhat.com> <20120509190529.GI15555@adacore.com> <20120509190753.GA31769@adacore.com> <87ehqtru0d.fsf@fleche.redhat.com> <20120509204023.GM15555@adacore.com> Date: Wed, 09 May 2012 20:57:00 -0000 In-Reply-To: <20120509204023.GM15555@adacore.com> (Joel Brobecker's message of "Wed, 9 May 2012 13:40:23 -0700") Message-ID: <87lil1qdin.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00321.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I did a second audit, and found that a lot of those uses were for Joel> purposes other than symbol lookup (finding the symtab associated Joel> a PC, for instance), so an update shouldn't be needed there. [...] Sounds good. Thanks for looking. Joel> There are also some locations where the loop is inside a routine Joel> that does a lookup without "context". For instance, Joel> basic_lookup_transparent_type. In that case, the only real caller Joel> I could find was check_typedef, which I don't think we want to Joel> change. I'm not so sure. It seems like you could make a multi-objfile test case where an incomplete type is incorrectly resolved to a type in another objfile. Tom