From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91763-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14776 invoked by alias); 4 Jun 2012 20:32:08 -0000
Received: (qmail 14763 invoked by uid 22791); 4 Jun 2012 20:32:07 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_YY,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 20:31:48 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q54KVm2r026730	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 4 Jun 2012 16:31:48 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q54KVl7R029059	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 4 Jun 2012 16:31:47 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 03/10] C language
References: <1338665528-5932-1-git-send-email-sergiodj@redhat.com>	<1338665528-5932-4-git-send-email-sergiodj@redhat.com>
Date: Mon, 04 Jun 2012 20:32:00 -0000
In-Reply-To: <1338665528-5932-4-git-send-email-sergiodj@redhat.com> (Sergio	Durigan Junior's message of "Sat, 2 Jun 2012 16:32:01 -0300")
Message-ID: <87lik2n7ik.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00096.txt.bz2

Sergio> +#define	yyparse	_c_parse

It is pedantically better to avoid names with a leading underscore.
While it probably will never cause any problem in practice, I think it
is also just as easy to pick pedantically-correct names at the outset.

So, could you rename these to $LANG_parse_internal or something like that?

Sergio> -  result = yyparse ();
Sergio> +  result = _c_parse ();

I think you don't need to change this line.

>From a spot check it appears these comments apply to all the other yacc
parsers in the series.

Tom