From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93043-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3967 invoked by alias); 24 Jul 2012 19:36:05 -0000
Received: (qmail 3815 invoked by uid 22791); 24 Jul 2012 19:36:05 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 19:35:52 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6OJZpgg021720	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 24 Jul 2012 15:35:51 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6OJZo2w027482	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 24 Jul 2012 15:35:50 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Keith Seitz <keiths@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
References: <CANFwon22Tt57WcsDE8rPrSjgxg62MbgsN0WrAELu9Y52RDwUGg@mail.gmail.com>	<500C0A1F.8040106@redhat.com>	<CANFwon2u=xV4XqKV33Fqk_1k7QQQWixMDNNjJKM01tkV4dTWxQ@mail.gmail.com>	<87k3xusgan.fsf@fleche.redhat.com>	<CANFwon2KzfyOzhV625S7xqMAw6+iLjmUz8oHjaC=T=PUshUZZw@mail.gmail.com>
Date: Tue, 24 Jul 2012 19:36:00 -0000
In-Reply-To: <CANFwon2KzfyOzhV625S7xqMAw6+iLjmUz8oHjaC=T=PUshUZZw@mail.gmail.com>	(Hui Zhu's message of "Tue, 24 Jul 2012 11:47:55 +0800")
Message-ID: <87lii9ne95.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00499.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> 2012-07-24  Hui Zhu  <hui_zhu@mentor.com>
>> 	* linespec.c (linespec_lexer_lex_number): Update comments,
>> 	change the return and add check to make sure the input is
>> 	the decimal numbers.
>> 	(linespec_lexer_lex_one): If linespec_lexer_lex_number return
>> 	false, call linespec_lexer_lex_string.

>> +static int
>> +linespec_lexer_lex_number (linespec_parser *parser, linespec_token *tokenp)
>>  {
>>    linespec_token token;

After this change, I think 'token' is unused.

The patch is ok if you update it to remove this.

thanks,
Tom