From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93051-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12608 invoked by alias); 24 Jul 2012 20:50:48 -0000
Received: (qmail 12600 invoked by uid 22791); 24 Jul 2012 20:50:48 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 20:50:28 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6OKoO07007852	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 24 Jul 2012 16:50:25 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6OKoM5t020127	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 24 Jul 2012 16:50:23 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/6] new add_setshow_enum_cmd_with_notif and scheduler-locking.
References: <1343146252-22558-1-git-send-email-yao@codesourcery.com>	<1343146252-22558-5-git-send-email-yao@codesourcery.com>
Date: Tue, 24 Jul 2012 20:50:00 -0000
In-Reply-To: <1343146252-22558-5-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Wed, 25 Jul 2012 00:10:50 +0800")
Message-ID: <87lii8nasx.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00507.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2012-07-23  Yao Qi  <yao@codesourcery.com>
Yao> 	* cli/cli-decode.c (add_setshow_enum_cmd_with_notif): New.
Yao> 	* command.h: Declare.
Yao> 	* infrun.c (_initialize_infrun): Call
Yao>  	add_setshow_enum_cmd_with_notif.

This part seems fine, though of course pending on the earlier patch and
discussion about the overall approach.

I wish there were a nice way to do without yet another
command-registration function.  We already have a dizzying variety.

Yao> +set testfile "basics"
Yao> +set srcfile ${testfile}.c
Yao> +set binfile ${objdir}/${subdir}/mi-cmd-opt-changed

Please use standard_testfile now.

Tom