From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16814 invoked by alias); 6 Aug 2012 20:21:13 -0000 Received: (qmail 16783 invoked by uid 22791); 6 Aug 2012 20:21:12 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Aug 2012 20:20:54 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q76KKnwK020038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Aug 2012 16:20:49 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q76KKlgF028923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 6 Aug 2012 16:20:48 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 1/3] new observer command_param_changed. References: <1343992904-9375-1-git-send-email-yao@codesourcery.com> <1343992904-9375-2-git-send-email-yao@codesourcery.com> <87zk6bnakg.fsf@fleche.redhat.com> <1445113.LnrSLk2Yru@qiyao.dyndns.org> Date: Mon, 06 Aug 2012 20:21:00 -0000 In-Reply-To: <1445113.LnrSLk2Yru@qiyao.dyndns.org> (Yao Qi's message of "Mon, 6 Aug 2012 23:44:14 +0800") Message-ID: <87lihrixgg.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00197.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> They are switched to dynamic array. Thanks. Yao> + /* Update the field 'prefix' of each cmd_list_element in *PREFIXLIST. */ Yao> + for (p = *prefixlist; p != NULL; p = p->next) Yao> + p->prefix = c; Super. Yao> { Yao> + char *name; Yao> + Yao> + /* Compute the whole multi-word command options. If user types command Yao> + 'set foo bar baz on', c->name is 'baz', and GDB can't pass "bar" to Yao> + command option change notification, because it is confusing. We can Yao> + trace back through field 'prefix' to compute the whole options, Yao> + and pass "foo bar baz" to notification. */ Yao> + { Two blocks separated only by a declaration seems unusual. I would suggest just a single block. Yao> + /* Skip the command 'set' in CMDS. */ Yao> + i--; Yao> + gdb_assert (cmds[i]->prefixlist == &setlist); I wonder if this can trigger somehow. For example, if a Python programmer makes a Parameter under 'maint set' that is in an unexpected command class. I think it would be safer perhaps to just avoid the notification if the prefixlist is not setlist. Tom