Re: [PATCH] Add extern of output_command to utils.h

Hui Zhu
2013-01-05T05:37:21Z

On Fri, Jan 4, 2013 at 10:45 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> What about add this extern to valprint.h that is included by printcmd.c?
>
> That sounds ok to me.
>
> Tom

Post a new version according to that. Please help me review it.

Thanks,
Hui

2013-01-05 Hui Zhu <hui_zhu@mentor.com>

* tracepoint.c: Remove extern of function output_command.
* valprint.h.h (output_command): New extern.

--- a/tracepoint.c
+++ b/tracepoint.c
@@ -93,11 +93,6 @@ extern void (*deprecated_readline_begin_
extern char *(*deprecated_readline_hook) (char *);
extern void (*deprecated_readline_end_hook) (void);

-/* GDB commands implemented in other modules:
- */
-
-extern void output_command (char *, int);
-
/*
Tracepoint.c:

--- a/valprint.h
+++ b/valprint.h
@@ -205,4 +205,6 @@ extern void generic_printstr (struct ui_
int quote_char, int c_style_terminator,
const struct value_print_options *options);

+extern void output_command (char *, int);
+
#endif