From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8476 invoked by alias); 19 Apr 2013 14:33:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8467 invoked by uid 89); 19 Apr 2013 14:33:25 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 14:33:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEXND6013835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Apr 2013 10:33:24 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEXMgw003737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 10:33:23 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 12/28] add decref in evpy_emit_event References: <87ehe638ww.fsf@fleche.redhat.com> Date: Fri, 19 Apr 2013 14:42:00 -0000 In-Reply-To: <87ehe638ww.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 19 Apr 2013 08:13:51 -0600") Message-ID: <87li8ezj2l.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00595.txt.bz2 The checker noticed a missing decref in evpy_emit_event. * python/py-event.c (evpy_emit_event): Decref the result of PyObject_CallFunctionObjArgs. --- gdb/python/py-event.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gdb/python/py-event.c b/gdb/python/py-event.c index 2c18e2f..afd07fe 100644 --- a/gdb/python/py-event.c +++ b/gdb/python/py-event.c @@ -111,16 +111,23 @@ evpy_emit_event (PyObject *event, for (i = 0; i < PyList_Size (callback_list_copy); i++) { PyObject *func = PyList_GetItem (callback_list_copy, i); + PyObject *func_result; if (func == NULL) goto fail; - if (!PyObject_CallFunctionObjArgs (func, event, NULL)) + func_result = PyObject_CallFunctionObjArgs (func, event, NULL); + + if (func_result == NULL) { /* Print the trace here, but keep going -- we want to try to call all of the callbacks even if one is broken. */ gdbpy_print_stack (); } + else + { + Py_DECREF (func_result); + } } Py_XDECREF (callback_list_copy); -- 1.8.1.4