From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106168-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9766 invoked by alias); 9 Oct 2013 15:48:22 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9753 invoked by uid 89); 9 Oct 2013 15:48:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 15:48:21 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99FmKmM028931	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 9 Oct 2013 11:48:20 -0400
Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r99FmJpR021714	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 9 Oct 2013 11:48:19 -0400
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Kai Tietz <ktietz@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patchv2] Minor O_CLOEXEC optimization, "regression" fix
References: <20131008183214.GB27355@host2.jankratochvil.net>	<87li23fsym.fsf@fleche.redhat.com>	<20131009131016.GA1603@host2.jankratochvil.net>	<173490856.4156973.1381325657769.JavaMail.root@redhat.com>	<20131009144134.GA7506@host2.jankratochvil.net>
Date: Wed, 09 Oct 2013 15:48:00 -0000
In-Reply-To: <20131009144134.GA7506@host2.jankratochvil.net> (Jan Kratochvil's	message of "Wed, 9 Oct 2013 16:41:34 +0200")
Message-ID: <87li22cunx.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-10/txt/msg00281.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Wed, 09 Oct 2013 15:34:17 +0200, Kai Tietz wrote:
>> So yes, probing for EINVAL seems to me like a valid way to probe for valid
>> arguments here.

Jan> OK, therefore updated the patch.

Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora21pre-linux-gnu.
Jan> It still reduces the number of syscalls.

Looks good to me.

Tom