From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31150 invoked by alias); 8 Nov 2013 14:42:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31139 invoked by uid 89); 8 Nov 2013 14:42:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2013 14:42:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA8EgNje003843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Nov 2013 09:42:23 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA8EgHFj023487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Nov 2013 09:42:20 -0500 From: Tom Tromey To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFA/Ada(v2) 1/3] Add command to list Ada exceptions References: <1383912219-13012-1-git-send-email-brobecker@adacore.com> <1383912219-13012-2-git-send-email-brobecker@adacore.com> <527CDD03.9000200@redhat.com> <20131108133725.GA4585@adacore.com> Date: Fri, 08 Nov 2013 15:47:00 -0000 In-Reply-To: <20131108133725.GA4585@adacore.com> (Joel Brobecker's message of "Fri, 8 Nov 2013 17:37:25 +0400") Message-ID: <87li0zq7jq.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00239.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> +VEC(ada_exc_info) * Joel> +ada_exceptions_list (const char *regexp) Joel> +{ Joel> + VEC(ada_exc_info) *result = NULL; Joel> + struct cleanup *old_chain Joel> + = make_cleanup (VEC_cleanup (ada_exc_info), &result); Joel> + regex_t *preg = NULL; Joel> + int prev_len; Joel> + Joel> + if (regexp != NULL) Joel> + { Joel> + preg = alloca (sizeof (regex_t)); I think regex_t is sufficiently small that you might as well declare an object in the outer scope and avoid alloca. Joel> + discard_cleanups (old_chain); This leaks anything done by compile_rx_or_error. I think you need to pass an inner cleanup to do_cleanups. Tom