From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make "backtrace" doesn't print python stack if init python dir get fail
Date: Tue, 03 Dec 2013 20:27:00 -0000 [thread overview]
Message-ID: <87li01smua.fsf@fleche.redhat.com> (raw)
In-Reply-To: <529D8865.80503@mentor.com> (Hui Zhu's message of "Tue, 3 Dec 2013 15:29:41 +0800")
>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
Hui> I got a issue is ensure_python_env check gdb_python_initialized and
Hui> throw error if it is 0. So gdb_python_initialized to 0 will make
Hui> some commands throw error when python dir has something error. I
Hui> removed this check in the patch.
I think that's a useful consistency check, so better left in place.
Two other approaches are possible here instead. One, change
finish_python_initialization to do the needed bit of locking by handy,
not using ensure_python_env. Or, two, don't release the GIL until
somewhere in finish_python_initialization, and then it doesn't need
to call ensure_python_env at all.
Tom
next prev parent reply other threads:[~2013-12-03 20:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 17:35 Hui Zhu
2013-12-02 16:05 ` Tom Tromey
2013-12-03 7:30 ` Hui Zhu
2013-12-03 20:27 ` Tom Tromey [this message]
2013-12-04 7:41 ` Hui Zhu
2013-12-11 17:07 ` Tom Tromey
2013-12-13 11:49 ` Hui Zhu
2014-01-14 16:09 ` Tom Tromey
2014-01-14 17:41 ` Tom Tromey
2014-01-14 21:32 ` Phil Muldoon
2014-01-15 20:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li01smua.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox