From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18992 invoked by alias); 11 Dec 2013 22:03:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18965 invoked by uid 89); 11 Dec 2013 22:02:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2013 22:02:55 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBBM2sBO016102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 Dec 2013 17:02:54 -0500 Received: from barimba (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBBM2quX028243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 11 Dec 2013 17:02:52 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 3/9] add target method delegation References: <1382464769-2465-1-git-send-email-tromey@redhat.com> <1382464769-2465-4-git-send-email-tromey@redhat.com> <526E8B54.8040104@redhat.com> <87eh75cmig.fsf@fleche.redhat.com> <87a9htcme3.fsf@fleche.redhat.com> <87habz7q6g.fsf@fleche.redhat.com> <527D1A84.9040106@redhat.com> Date: Wed, 11 Dec 2013 22:03:00 -0000 In-Reply-To: <527D1A84.9040106@redhat.com> (Pedro Alves's message of "Fri, 08 Nov 2013 17:08:20 +0000") Message-ID: <87lhzr11wz.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-12/txt/msg00456.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So to take that example, if we made dummy_target.to_wait be the Pedro> current to_wait default, which is to call noprocess(), then Pedro> it'd be clear that target_delegate_wait shouldn't ever go past Pedro> the loop, and then it'd be clear that an assertion is appropriate. Pedro> target_wait would then be: [...] Pedro> WDYT? It seems good to me. I'll make a patch to normalize the delegation across all the target methods. Too bad for me I already touched all these methods on the multi-target branch -- ouch. Testing revealed that we can't put the assert into target_delegate_async. This is a funny one. The dummy target has: dummy_target.to_can_async_p = find_default_can_async_p; ... but this means that it is possible for to_can_async_p to return true while the target does not actually implement to_async. Tom