From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28332 invoked by alias); 19 May 2014 19:19:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28314 invoked by uid 89); 19 May 2014 19:19:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 May 2014 19:19:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4JJJEZJ011167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2014 15:19:15 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4JJJDXn003383 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 19 May 2014 15:19:14 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v5 5/8] Move linux_find_memory_regions_full & co. References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223107.14668.6979.stgit@host1.jankratochvil.net> Date: Mon, 19 May 2014 19:19:00 -0000 In-Reply-To: <20140319223107.14668.6979.stgit@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 19 Mar 2014 23:31:07 +0100") Message-ID: <87lhtxwp8u.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00372.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> this should be just a move with no changes. Jan> 2014-02-26 Aleksandar Ristovski Move linux_find_memory_regions_full & co. Jan> * common/target-utils.c (string.h, gdb_assert.h): Include. Jan> (read_alloc, read_stralloc): Move definitions from target.c. Jan> * common/target-utils.h (read_alloc_pread_ftype): New typedef. Jan> (read_alloc): New declaration. Jan> (read_stralloc_func_ftype): New typedef. Jan> (read_stralloc): New declaration. Jan> * common/linux-maps.c (fcntl.h, unistd.h, target.h, gdb_assert.h) Jan> (ctype.h, string.h, target-utils.h): Include. Jan> (read_mapping): Move from linux-tdep.c. Jan> [GDBSERVER] (linux_find_memory_read_stralloc_1_pread): New function. Jan> [GDBSERVER] (linux_find_memory_read_stralloc_1): New function. Jan> (linux_find_memory_read_stralloc): New function. Jan> (linux_find_memory_regions_full): Move from linux-tdep.c. Jan> * common/linux-maps.h (read_mapping): New declaration. Jan> (linux_find_memory_region_ftype): Moved typedef from linux-tdep.c. Jan> (linux_find_memory_regions_full): New declaration. Jan> * linux-tdep.c (linux-maps.h): Include. Jan> (read_mapping): Moved to common/linux-maps.c. Jan> (linux_find_memory_region_ftype): Moved typedef to common/linux-maps.h. Jan> (linux_find_memory_regions_full): Moved definition to Jan> common/linux-maps.c. Jan> * target.c (target-utils.h): Include. Jan> (read_alloc_pread_ftype): Moved typedef to common/target-utils.h. Jan> (read_alloc, read_stralloc): Moved definitions to Jan> common/target-utils.c. Ok. I appreciate how the patch series was constructed to make this patch obvious. Thanks. Tom