From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11249 invoked by alias); 29 Jul 2014 15:14:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32368 invoked by uid 89); 29 Jul 2014 14:49:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Jul 2014 14:49:12 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6TEnBY7001162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jul 2014 10:49:11 -0400 Received: from barimba (ovpn-113-151.phx2.redhat.com [10.3.113.151]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6TEnAAp008192 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 29 Jul 2014 10:49:10 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] baby step toward multi-target References: <1405711635-1102-1-git-send-email-tromey@redhat.com> <53D7AE46.8080303@redhat.com> Date: Tue, 29 Jul 2014 15:15:00 -0000 In-Reply-To: <53D7AE46.8080303@redhat.com> (Pedro Alves's message of "Tue, 29 Jul 2014 15:23:02 +0100") Message-ID: <87lhrccja2.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-07/txt/msg00743.txt.bz2 Tom> If this approach seems reasonable then it's not too hard to pull over Tom> some of the other target conversions from the branch. Pedro> Seems reasonable. We may or not end up doing things completely Pedro> different wrt to the identify issue and target is pushed/not pushed, Pedro> but meanwhile this lets us progress with making it possible to have Pedro> different instances of a target, so it seems good forward progress. Pedro> The series looked good to me. Thanks for looking. I actually went a bit farther down this path on my branch, adding: 0249cca turn remote into a to_xclose target 84e2677 turn linux-thread-db into a to_xclose target 9fdaa64 fix exec_close to be multi-target-aware 7fd03ff introduce the target stack 698a56f convert current_target to be a pointer 68520c8 convert exec target to to_xclose These are all things pulled over from the mostly-defunct multi-target branch. I probably wouldn't be inclined to put these -- or maybe even the bulk of the "baby step" series -- in right now. They aren't really that useful until some other things are finished, like adding the target ID to ptid. However, it's probably useful as a starting point for the next attempt at multi-target. In particular it's much less invasive than the earlier approach, and the "convert current_target to be a pointer" patch (the biggest one) was mostly done with a perl one-liner. Tom