Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram

Yao Qi
2014-08-25T12:13:25Z

Pedro Alves <palves@redhat.com> writes:

> Hmm. I still can't parse this though. It's actually the "to the" part
> that seems to miss a verb to me. Isn't a "Set" missing instead of
> "are"? Like:
>
> that this subprogram contains. If SET_ADDRMAP is true, record the
> covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest and
> highest PC values found in PDI.

Sigh, my brain stopped working! Sorry about that. Fix it as you suggested.

--
Yao (齐尧)

commit 9afcfde91565f7fa16e77794cef0a05ebe77bf1b
Author: Yao Qi <yao@codesourcery.com>
Date: Mon Aug 25 20:01:45 2014 +0800

Fix grammatical error in comments

gdb:

2014-08-25 Yao Qi <yao@codesourcery.com>

* dwarf2read.c: Fix grammatical error.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index df6deef..4720198 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -7007,8 +7007,8 @@ add_partial_module (struct partial_die_info *pdi, CORE_ADDR *lowpc,
symbol for that subprogram. When the CU language allows it, this
routine also defines a partial symbol for each nested subprogram
that this subprogram contains. If SET_ADDRMAP is true, record the
- covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
- highest PC values are found in PDI.
+ covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest
+ and highest PC values found in PDI.

PDI may also be a lexical block, in which case we simply search
recursively for subprograms defined inside that lexical block.