Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram

Pedro Alves
2014-08-22T16:41:01Z

Hi Yao,

On 08/22/2014 01:02 PM, Yao Qi wrote:

> /* Read a partial die corresponding to a subprogram and create a partial
> symbol for that subprogram. When the CU language allows it, this
> routine also defines a partial symbol for each nested subprogram
> - that this subprogram contains.
> + that this subprogram contains. If SET_ADDRMAP is true, record the
> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
> + highest PC values found in PDI.

The last sentence is missing the verb?

> - DIE my also be a lexical block, in which case we simply search
> + PDI may also be a lexical block, in which case we simply search
> recursively for suprograms defined inside that lexical block.

As long as we're fixing typos, there's another here "suprograms".

Otherwise looks fine to me.

Thanks,
Pedro Alves