Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram

Pedro Alves
2014-08-25T09:58:05Z

On 08/24/2014 02:48 PM, Yao Qi wrote:
>>> >> - that this subprogram contains.
>>> >> + that this subprogram contains. If SET_ADDRMAP is true, record the
>>> >> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
>>> >> + highest PC values found in PDI.
>> >
>> > The last sentence is missing the verb?
> Ur, "are" is missing, I think. It should be "... are found in PDI.".
> Fixed in the updated patch.

...

> + that this subprogram contains. If SET_ADDRMAP is true, record the
> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
> + highest PC values are found in PDI.

Hmm. I still can't parse this though. It's actually the "to the" part
that seems to miss a verb to me. Isn't a "Set" missing instead of
"are"? Like:

that this subprogram contains. If SET_ADDRMAP is true, record the
covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest and
highest PC values found in PDI.

Thanks,
Pedro Alves