From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7571 invoked by alias); 11 Sep 2014 23:21:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7562 invoked by uid 89); 11 Sep 2014 23:21:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 11 Sep 2014 23:20:50 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8BNKiub026163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Sep 2014 19:20:44 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8BNKiUs003779 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 11 Sep 2014 19:20:44 -0400 From: Sergio Durigan Junior To: Edjunior Barbosa Machado Cc: gdb-patches@sourceware.org, Ulrich Weigand Subject: Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid References: <1410476585-18046-1-git-send-email-emachado@linux.vnet.ibm.com> X-URL: http://www.redhat.com Date: Thu, 11 Sep 2014 23:21:00 -0000 In-Reply-To: <1410476585-18046-1-git-send-email-emachado@linux.vnet.ibm.com> (Edjunior Barbosa Machado's message of "Thu, 11 Sep 2014 20:03:05 -0300") Message-ID: <87lhpp68xf.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00378.txt.bz2 On Thursday, September 11 2014, Edjunior Barbosa Machado wrote: > The problem is that rs6000_frame_cache attempts to read the stack backchain via > read_memory_unsigned_integer, which throws an exception if the stack pointer is > invalid. With this path, it calls safe_read_memory_integer instead, which > doesn't throw an exception and allows for safe handling of that situation. > Regression tested on ppc64{,le}. Ok? Heya! Thanks for the patch. Not having reviewed the code deeply to understand if it's the best approach, I would just like to point that a testcase for this would be awesome. As it turns out, you actually already have a testcase almost written in the bug description :-). Again, thanks for addressing those issues! Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/